Update CMakeLists.txt to use target_compile_features instead of CMAKE_CXX_STANDARD
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 439
- Forks
- 90
- PR merge metrics
- No merged PRs in 30d
Description
Now that we're targeting platforms with cmake-3.16+ available, we should use target_compile_features with cxx_std_## instead of set(CMAKE_CXX_STANDARD ##). Using target_compile_features helps downstream packages to identify the minimum standard that their compiler needs to support.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with rmf_traffic_ros2/CMakeLists.txt at the referenced CMAKE_CXX_STANDARD setting and inspect the target declarations around it. Update the project to express the required C++ standard through target_compile_features and verify that downstream packages can identify the minimum compiler standard.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100