open-feature / open-feature/python-sdk
[BUG] before hooks do not receive the evaluation context returned by earlier before hooks
Chưa có ai nhận issue này.
- Ngôn ngữ chính
- Python
- Star
- 111
- Fork
- 44
- Merge trung bình
- 2 giờ 37 phút
- Pull request đã merge (30 ngày)
- 14
Mô tả
Observed behaviour
Requirement 4.3.4 says:
Any
evaluation contextreturned from abeforehook MUST be passed to subsequentbefore
hooks (viaHookContext).
Each hook receives a HookContext built before any hook ran, so a hook never sees what an earlier
hook contributed.
The final merge into the evaluation context is correct — the provider does receive every hook's
contribution, so 3.2.2
and 4.3.5 are satisfied.
Only the propagation half is missing.
Reproducer
Against main (bd3b1e6):
from openfeature import api
from openfeature.client import OpenFeatureClient
from openfeature.evaluation_context import EvaluationContext
from openfeature.flag_evaluation import FlagEvaluationOptions
from openfeature.hook import Hook, HookContext
from openfeature.provider.in_memory_provider import InMemoryFlag, InMemoryProvider
observed = {}
class ContributingHook(Hook):
"""Adds one attribute, and records what it could see when it ran."""
def __init__(self, name, adds):
self.name = name
self.adds = adds
def before(self, hook_context: HookContext, hints):
observed[self.name] = dict(hook_context.evaluation_context.attributes)
return EvaluationContext(attributes=self.adds)
class RecordingProvider(InMemoryProvider):
def resolve_boolean_details(self, flag_key, default_value, evaluation_context=None):
observed["provider"] = dict(evaluation_context.attributes) if evaluation_context else {}
return super().resolve_boolean_details(flag_key, default_value, evaluation_context)
api.set_provider(RecordingProvider({"flag": InMemoryFlag("on", {"on": True, "off": False})}))
client: OpenFeatureClient = api.get_client()
client.add_hooks([ContributingHook("hook_a", {"from_hook_a": "a"})])
# hook_b is an invocation hook, so it runs after the client hook (API -> client -> invocation).
client.get_boolean_details(
"flag",
False,
evaluation_context=EvaluationContext(attributes={"from_invocation": "i"}),
flag_evaluation_options=FlagEvaluationOptions(
hooks=[ContributingHook("hook_b", {"from_hook_b": "b"})]
),
)
print("hook_a saw :", observed["hook_a"])
print("hook_b saw :", observed["hook_b"])
print("provider :", observed["provider"])
Output:
hook_a saw : {'from_invocation': 'i'}
hook_b saw : {'from_invocation': 'i'}
provider : {'from_invocation': 'i', 'from_hook_a': 'a', 'from_hook_b': 'b'}
hook_b should have seen from_hook_a: a. The provider line shows the final merge is fine.
Cause
OpenFeatureClient._establish_hooks_and_provider constructs one HookContext per hook up front,
all from the same merged_eval_context:
merged_hooks_and_context = [
(
hook,
HookContext(
flag_key=flag_key,
flag_type=flag_type,
default_value=default_value,
evaluation_context=merged_eval_context,
client_metadata=client_metadata,
provider_metadata=provider_metadata,
hook_data={},
),
)
for hook in chain(get_hooks(), self.hooks, evaluation_hooks, provider.get_provider_hooks())
]
_hook_support._execute_hooks_unchecked then iterates those pairs without ever updating one:
return [
getattr(hook, hook_method.value)(hook_context=hook_context, **kwargs)
for (hook, hook_context) in hooks_and_context
if hook.supports_flag_value_type(flag_type)
]
before_hooks reduces the results correctly (reduce(lambda a, b: a.merge(b), filtered_hooks)),
which is why the provider still gets everything — but that accumulation is never fed back into the
hook contexts.
The docstring on _run_before_hooks_and_update_context cites 4.3.4 while implementing only the
merge half.
Suggested fix
Accumulate as the hooks run and refresh the context handed to each subsequent hook, rather than
collecting results and merging once at the end. Roughly:
def before_hooks(flag_type, hooks_and_context, hints=None):
accumulated = EvaluationContext()
for hook, hook_context in hooks_and_context:
if not hook.supports_flag_value_type(flag_type):
continue
hook_context.evaluation_context = hook_context.evaluation_context.merge(accumulated)
result = hook.before(hook_context=hook_context, hints=hints)
if result is not None:
accumulated = accumulated.merge(result)
return accumulated
HookContext is a plain mutable class (__init__-assigned attributes, not frozen), so assigning
evaluation_context in place works; rebuilding the context per hook is equally fine. dotnet-sdk does
the latter (WithNewEvaluationContext applied to every pending hook context); ruby-sdk does the
former.
Cross-language note
Surveyed 2026-09-14 — js-sdk, java-sdk, dotnet-sdk and ruby-sdk all propagate correctly.
go-sdk had a related but distinct bug (results replaced rather than merged), reported as
go-sdk#549 and fixed by
go-sdk#569. php-sdk has the same propagation gap
as this one.
Given four SDKs have now been found wanting on one half or the other, this seems like a good
candidate for a shared e2e/TCK case: two before hooks at different levels, each returning a distinct
key; assert both reach the provider and that the second hook observed the first's key. Asserting
only the merged result would miss this bug entirely.
Hướng dẫn đóng góp
Bắt đầu từ đâu
- Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
- Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
- Fork repository và làm thay đổi trên một nhánh.
- Mở pull request có tham chiếu số hiệu của issue.
Hướng nghiên cứu
Bắt đầu từ OpenFeatureClient._establish_hooks_and_provider và _hook_support._execute_hooks_unchecked, sau đó lần theo _run_before_hooks_and_update_context và phép reduction của before_hooks. Đảm bảo mỗi before hook tiếp theo nhận được các đóng góp trước đó, đồng thời giữ nguyên context cuối cùng đã được merge của provider. Thêm một regression case sử dụng hai hook ở các cấp khác nhau để kiểm tra cả những gì hook thứ hai quan sát được và những gì provider nhận được.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Công nghệ
- python
- Lĩnh vực
- backend-api-design
- Loại issue
- Lỗi
- Độ khó
- 3/5
- Thời gian dự kiến
- 1-2 ngày
- Mức độ hoạt động
- Sôi nổi
- Độ rõ ràng
- Đặc tả rõ ràng
- Mức phù hợp với người mới
- 78/100