Request signal isn't aborted after garbage collection

Bug Description

Passing a signal to Request() and aborting it does not cause the underlying request signal to be aborted after it's been garbage collected. This leads to issues where you want to listen on the request signal even after the request itself falls out of scope - e.g., the request is instantiated with an abort controller signal and downstream code is waiting for that signal to be aborted via request.signal.

Reproducible By

Run the following using node --expose-gc main.js:

const ac = new AbortController();

ac.signal.addEventListener("abort", () => {
  console.log("ac signal aborted");
});

const request = new Request("https://google.ca", { signal: ac.signal });

request.signal.addEventListener("abort", () => {
  console.log("request signal aborted");
});

setTimeout(() => {
  global.gc();
  ac.abort();
}, 0);

Expected Behavior

ac signal aborted and request signal aborted should be logged to the console.

Instead, only ac signal aborted is logged.

Environment

Latest node and undici. Tried it in some older versions as well.

Additional context

A few folks are running into this while trying to close event stream requests in the remix web framework. The underlying requests are never closed because the signal doesn't get aborted.

Beginne damit, die bereitgestellte main.js-Reproduktion mit node --expose-gc auszuführen, und verfolge anschließend Request(), request.signal und die Weiterleitung des AbortController-Signals durch die relevante Node.js-Implementierung. Als erledigt gilt die Aufgabe, wenn nach der Garbage Collection und dem Abbrechen des Controllers sowohl “ac signal aborted” als auch “request signal aborted” protokolliert werden und der reproduzierte Fall durch Tests abgedeckt ist.