Wrong error annotation when commonjs `require`s an ES module
未关闭
还没有人认领这个 Issue。
confirmed-bug
- 主要语言
- JavaScript
- 星标
- 122k
- 派生
- 37.3k
- 平均合并
- 4 天 2 小时
- 30 天内合并 PR
- 283
描述
Version
^22.4.0mainwith the--no-experimental-require-moduleflag.
Platform
macOS arm64
Subsystem
esm,module
What steps will reproduce the bug?
mkdir undefined && cd undefined
echo '{"type":"module"}' > package.json
echo "import nothing from 'somewhere'" > app.js
echo "require('./app.js')" > test.cjs
node test.cjs
How often does it reproduce? Is there a required condition?
It starts to happen with v22.4.0. v20.x and <=22.3.0 are not affected.
What is the expected behavior? Why is that the expected behavior?
$ node test.cjs
/Users/mzasso/git/test/undefined/test.cjs:1
require('./app.js')
^
Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/mzasso/git/test/undefined/app.js from /Users/mzasso/git/test/undefined/test.cjs not supported.
Instead change the require of app.js in /Users/mzasso/git/test/undefined/test.cjs to a dynamic import() which is available in all CommonJS modules.
at Object.<anonymous> (/Users/mzasso/git/test/undefined/test.cjs:1:1) {
code: 'ERR_REQUIRE_ESM'
}
Node.js v22.3.0
What do you see instead?
$ node test.cjs
/Users/mzasso/git/test/undefined/test.cjs:315
undefined
^
Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/mzasso/git/test/undefined/app.js from /Users/mzasso/git/test/undefined/test.cjs not supported.
Instead change the require of app.js in /Users/mzasso/git/test/undefined/test.cjs to a dynamic import() which is available in all CommonJS modules.
at TracingChannel.traceSync (node:diagnostics_channel:315:14)
at Object.<anonymous> (/Users/mzasso/git/test/undefined/test.cjs:1:1) {
code: 'ERR_REQUIRE_ESM'
}
Node.js v22.4.0
Additional information
As you can see, this seems to be caused by the presence of TracingChannel.traceSync in the stack trace.
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
首先使用 Node.js v22.4.0 和 --no-experimental-require-module 标志运行 issue 中的复现命令,然后跟踪 ESM/CommonJS require 错误和 TracingChannel.traceSync 的堆栈注释。完成的标准是:错误注释如预期输出所示指向 require('./app.js') 行,并且有一个覆盖所报告版本变更的回归测试。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- javascript
- 领域
- backend
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 38/100