nodejs / nodejs/node

`node:child_process.fork` does not generate cpu-prof when process is killed

Abierto
#55,094 6 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

child_process
Lenguaje dominante
JavaScript
Estrellas
122k
Forks
37.3k
Merge medio
4 d 2 h
PR fusionados (30 d)
283

Descripción

Version

v20.17.0

Platform
Darwin Aris-MacBook-Air.local 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:16:46 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T8112 arm64
Subsystem

No response

What steps will reproduce the bug?
// repro.mjs
import { fork } from "node:child_process";
import { Worker } from "node:worker_threads";
import { existsSync, writeFileSync } from "node:fs";
import assert from "node:assert";

writeFileSync( "./example.mjs", `
console.log("Hello world");

// Keep alive
setInterval(() => {}, 1_000);
`, "utf8");

const subprocess = fork("./example.mjs", { execArgv: ["--cpu-prof", "--cpu-prof-dir=forks-profile"] });
const onExit = new Promise((r) => subprocess.on("exit", r));

await new Promise((r) => setTimeout(r, 1000));
subprocess.kill();
await onExit;

const thread = new Worker("./example.mjs", { execArgv: ["--cpu-prof", "--cpu-prof-dir=threads-profile"] });

await new Promise((r) => setTimeout(r, 1000));
await thread.terminate();

assert(existsSync("./threads-profile"), "Threads profile missing");
assert(existsSync("./forks-profile"), "Forks profile missing");
 $ node repro.mjs 
Hello world
Hello world
node:internal/modules/run_main:129
    triggerUncaughtException(
    ^

AssertionError [ERR_ASSERTION]: Forks profile missing
    at file:///x/repros/scripts/repro.mjs:26:1
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '=='
}

Node.js v20.17.0
How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

When a child process is killed with .kill(), it does not generate the CPU profile that --cpu-prof argument instructs it to do. I would expect profile to be generated.

This is inconsistent with node:worker_threads where terminating a Worker with .terminate() does still generate the profile. It also makes it difficult to debug slow child processes as you cannot get profile info without waiting for graceful exit.

What do you see instead?

Child process is killed and CPU profile is not written.

Additional information

No response

This issue has been marked as stale due to 210 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

Update to prevent being stale.

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza ejecutando repro.mjs con la versión de Node.js indicada y compara el proceso hijo bifurcado con el caso de Worker usando node:child_process.fork y node:worker_threads. Rastrea cómo --cpu-prof gestiona el cierre después de subprocess.kill() y, a continuación, añade o actualiza la cobertura para la reproducción. Se considera terminado cuando un hijo bifurcado al que se le ha enviado kill escribe un perfil de CPU de forma consistente, igual que el Worker terminado.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
javascript, node.js
Área
backend
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Tranquilo
Claridad
Bastante claro
Aptitud para principiantes
48/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.