`node:child_process.fork` does not generate cpu-prof when process is killed
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- JavaScript
- Sterne
- 122k
- Forks
- 37.3k
- Ø Merge
- 4 T. 2 Std.
- Gemergte PRs (30 T.)
- 283
Beschreibung
Version
v20.17.0
Platform
Darwin Aris-MacBook-Air.local 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:16:46 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T8112 arm64
Subsystem
No response
What steps will reproduce the bug?
// repro.mjs
import { fork } from "node:child_process";
import { Worker } from "node:worker_threads";
import { existsSync, writeFileSync } from "node:fs";
import assert from "node:assert";
writeFileSync( "./example.mjs", `
console.log("Hello world");
// Keep alive
setInterval(() => {}, 1_000);
`, "utf8");
const subprocess = fork("./example.mjs", { execArgv: ["--cpu-prof", "--cpu-prof-dir=forks-profile"] });
const onExit = new Promise((r) => subprocess.on("exit", r));
await new Promise((r) => setTimeout(r, 1000));
subprocess.kill();
await onExit;
const thread = new Worker("./example.mjs", { execArgv: ["--cpu-prof", "--cpu-prof-dir=threads-profile"] });
await new Promise((r) => setTimeout(r, 1000));
await thread.terminate();
assert(existsSync("./threads-profile"), "Threads profile missing");
assert(existsSync("./forks-profile"), "Forks profile missing");
$ node repro.mjs
Hello world
Hello world
node:internal/modules/run_main:129
triggerUncaughtException(
^
AssertionError [ERR_ASSERTION]: Forks profile missing
at file:///x/repros/scripts/repro.mjs:26:1
at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
generatedMessage: false,
code: 'ERR_ASSERTION',
actual: false,
expected: true,
operator: '=='
}
Node.js v20.17.0
How often does it reproduce? Is there a required condition?
Always
What is the expected behavior? Why is that the expected behavior?
When a child process is killed with .kill(), it does not generate the CPU profile that --cpu-prof argument instructs it to do. I would expect profile to be generated.
This is inconsistent with node:worker_threads where terminating a Worker with .terminate() does still generate the profile. It also makes it difficult to debug slow child processes as you cannot get profile info without waiting for graceful exit.
What do you see instead?
Child process is killed and CPU profile is not written.
Additional information
No response
This issue has been marked as stale due to 210 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
Update to prevent being stale.
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne damit, repro.mjs mit der gemeldeten Node.js-Version auszuführen, und vergleiche den geforkten Kindprozess mit dem Worker-Fall unter Verwendung von node:child_process.fork und node:worker_threads. Verfolge, wie --cpu-prof das Herunterfahren nach subprocess.kill() behandelt, und füge anschließend eine Abdeckung für die Reproduktion hinzu oder aktualisiere sie. Erledigt ist die Aufgabe, wenn ein gekilltes geforktes Kind konsistent ein CPU-Profil schreibt, ebenso wie der beendete Worker.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- javascript, node.js
- Bereich
- backend
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Ruhig
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 48/100