skipFiles does not suppress "uncaught" exceptions in web streams
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- JavaScript
- Estrellas
- 122k
- Forks
- 37.3k
- Merge medio
- 4 d 2 h
- PR fusionados (30 d)
- 283
Descripción
Version
22.4.1
Platform
Microsoft Windows NT 10.0.22635.0 x64
Subsystem
No response
What steps will reproduce the bug?
Run this code in the VSCode debugger with "skipFiles":["<node_internals>/**"] in the launch configuration.
import net from 'node:net';
import stream from 'node:stream';
const socket = net.connect('http://host.invalid.');
socket.on('error', (e) => {
console.error('Caught the error', e.message);
});
let myStream = stream.Duplex.toWeb(socket);
setTimeout(() => {
console.log('done');
}, 1000);
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior? Why is that the expected behavior?
It is expected that the debugger won't trip. This promise rejection is entirely created and handled within node's internals and should be suppressed by the VSCode's skipFiles filter.
What do you see instead?
The debugger breaks when the promise is rejected.
The trace (given by console.trace) when it is rejected looks like:
Trace
at eval (eval-7c2224bb.repl:1:9)
at Object.reject (<anonymous>)
at writableStreamRejectCloseAndClosedPromiseIfNeeded (node:internal/webstreams/writablestream:771:28)
at writableStreamFinishErroring (node:internal/webstreams/writablestream:903:5)
at writableStreamStartErroring (node:internal/webstreams/writablestream:755:5)
at writableStreamDefaultControllerError (node:internal/webstreams/writablestream:1202:3)
at WritableStreamDefaultController.error (node:internal/webstreams/writablestream:502:5)
at Socket.<anonymous> (node:internal/webstreams/adapters:195:18)
at Socket.<anonymous> (node:internal/util:538:20)
at Socket.onclose (node:internal/streams/end-of-stream:152:25)
The stack on the error object is:
'AbortError: The operation was aborted
at handleKnownInternalErrors (node:internal/webstreams/adapters:111:14)
at Socket.<anonymous> (node:internal/webstreams/adapters:179:13)
at Socket.<anonymous> (node:internal/util:538:20)
at Socket.onclose (node:internal/streams/end-of-stream:152:25)
at Socket.emit (node:events:532:35)
at Pipe.<anonymous> (node:net:339:12)
at Pipe.callbackTrampoline (node:internal/async_hooks:130:17)'
Additional information
No response
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Reproduce el ejemplo en el depurador de VSCode con skipFiles habilitado y, después, rastrea el rechazo a través de node:internal/webstreams/writablestream y node:internal/webstreams/adapters. Compara el tratamiento que hace el depurador de este rechazo creado internamente con los marcos de pila mostrados en el issue; el trabajo estará terminado cuando el rechazo interno ya no interrumpa la ejecución, mientras que los errores relevantes del código del usuario sigan siendo depurables.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- javascript, node.js
- Área
- backend, devtools
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Tranquilo
- Claridad
- Bastante claro
- Aptitud para principiantes
- 55/100