skipFiles does not suppress "uncaught" exceptions in web streams
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- JavaScript
- Sterne
- 122k
- Forks
- 37.3k
- Ø Merge
- 4 T. 2 Std.
- Gemergte PRs (30 T.)
- 283
Beschreibung
Version
22.4.1
Platform
Microsoft Windows NT 10.0.22635.0 x64
Subsystem
No response
What steps will reproduce the bug?
Run this code in the VSCode debugger with "skipFiles":["<node_internals>/**"] in the launch configuration.
import net from 'node:net';
import stream from 'node:stream';
const socket = net.connect('http://host.invalid.');
socket.on('error', (e) => {
console.error('Caught the error', e.message);
});
let myStream = stream.Duplex.toWeb(socket);
setTimeout(() => {
console.log('done');
}, 1000);
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior? Why is that the expected behavior?
It is expected that the debugger won't trip. This promise rejection is entirely created and handled within node's internals and should be suppressed by the VSCode's skipFiles filter.
What do you see instead?
The debugger breaks when the promise is rejected.
The trace (given by console.trace) when it is rejected looks like:
Trace
at eval (eval-7c2224bb.repl:1:9)
at Object.reject (<anonymous>)
at writableStreamRejectCloseAndClosedPromiseIfNeeded (node:internal/webstreams/writablestream:771:28)
at writableStreamFinishErroring (node:internal/webstreams/writablestream:903:5)
at writableStreamStartErroring (node:internal/webstreams/writablestream:755:5)
at writableStreamDefaultControllerError (node:internal/webstreams/writablestream:1202:3)
at WritableStreamDefaultController.error (node:internal/webstreams/writablestream:502:5)
at Socket.<anonymous> (node:internal/webstreams/adapters:195:18)
at Socket.<anonymous> (node:internal/util:538:20)
at Socket.onclose (node:internal/streams/end-of-stream:152:25)
The stack on the error object is:
'AbortError: The operation was aborted
at handleKnownInternalErrors (node:internal/webstreams/adapters:111:14)
at Socket.<anonymous> (node:internal/webstreams/adapters:179:13)
at Socket.<anonymous> (node:internal/util:538:20)
at Socket.onclose (node:internal/streams/end-of-stream:152:25)
at Socket.emit (node:events:532:35)
at Pipe.<anonymous> (node:net:339:12)
at Pipe.callbackTrampoline (node:internal/async_hooks:130:17)'
Additional information
No response
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Reproduziere das Beispiel im VSCode-Debugger mit aktiviertem skipFiles und verfolge dann die Ablehnung durch node:internal/webstreams/writablestream und node:internal/webstreams/adapters. Vergleiche die Behandlung dieser intern erstellten Ablehnung durch den Debugger mit den im Issue angezeigten Stack-Frames; abgeschlossen ist die Aufgabe, wenn die interne Ablehnung die Ausführung nicht mehr unterbricht, während relevante Fehler im Benutzercode weiterhin debuggbar bleiben.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- javascript, node.js
- Bereich
- backend, devtools
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Ruhig
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 55/100