skipFiles does not suppress "uncaught" exceptions in web streams
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 122k
- Forks
- 37.3k
- Avg merge
- 4d 2h
- Merged PRs (30d)
- 283
Description
Version
22.4.1
Platform
Microsoft Windows NT 10.0.22635.0 x64
Subsystem
No response
What steps will reproduce the bug?
Run this code in the VSCode debugger with "skipFiles":["<node_internals>/**"] in the launch configuration.
import net from 'node:net';
import stream from 'node:stream';
const socket = net.connect('http://host.invalid.');
socket.on('error', (e) => {
console.error('Caught the error', e.message);
});
let myStream = stream.Duplex.toWeb(socket);
setTimeout(() => {
console.log('done');
}, 1000);
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior? Why is that the expected behavior?
It is expected that the debugger won't trip. This promise rejection is entirely created and handled within node's internals and should be suppressed by the VSCode's skipFiles filter.
What do you see instead?
The debugger breaks when the promise is rejected.
The trace (given by console.trace) when it is rejected looks like:
Trace
at eval (eval-7c2224bb.repl:1:9)
at Object.reject (<anonymous>)
at writableStreamRejectCloseAndClosedPromiseIfNeeded (node:internal/webstreams/writablestream:771:28)
at writableStreamFinishErroring (node:internal/webstreams/writablestream:903:5)
at writableStreamStartErroring (node:internal/webstreams/writablestream:755:5)
at writableStreamDefaultControllerError (node:internal/webstreams/writablestream:1202:3)
at WritableStreamDefaultController.error (node:internal/webstreams/writablestream:502:5)
at Socket.<anonymous> (node:internal/webstreams/adapters:195:18)
at Socket.<anonymous> (node:internal/util:538:20)
at Socket.onclose (node:internal/streams/end-of-stream:152:25)
The stack on the error object is:
'AbortError: The operation was aborted
at handleKnownInternalErrors (node:internal/webstreams/adapters:111:14)
at Socket.<anonymous> (node:internal/webstreams/adapters:179:13)
at Socket.<anonymous> (node:internal/util:538:20)
at Socket.onclose (node:internal/streams/end-of-stream:152:25)
at Socket.emit (node:events:532:35)
at Pipe.<anonymous> (node:net:339:12)
at Pipe.callbackTrampoline (node:internal/async_hooks:130:17)'
Additional information
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the example in the VSCode debugger with skipFiles enabled, then trace the rejection through node:internal/webstreams/writablestream and node:internal/webstreams/adapters. Compare the debugger’s handling of this internally created rejection with the stack frames shown in the issue; done means the internal rejection no longer breaks execution while relevant user-code errors remain debuggable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- backend, devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100