Know when a process ended due to the `child_process.spawn()` `timeout` option
还没有人认领这个 Issue。
- 主要语言
- JavaScript
- 星标
- 122k
- 派生
- 37.4k
- 平均合并
- 4 天 3 小时
- 30 天内合并 PR
- 272
描述
What is the problem this feature will solve?
When a process ends due to the timeout option of child_process.spawn(), there is no way to know whether that termination was due to the timeout. A SIGTERM is sent to the process, but that's pretty much it.
import {spawn} from 'node:child_process'
const childProcess = spawn('node', ['-e', 'setTimeout(() => {}, 1e7)'], {
timeout: 2e3,
stdio: 'inherit', // no stdout/stderr
})
childProcess.on('exit', (exitCode, signal) => {
console.log({exitCode, signal}) // { exitCode: null, signal: 'SIGTERM' }
})
This makes debugging harder. Some users might be left wondering why the process ended if they don't pay attention to the timeout option.
What is the feature you are proposing to solve the problem?
Having a way to know whether the process ended due to the timeout option. Any implementation would work. Some potential ideas:
timeoutevent onchildProcess- third boolean argument
timedOutpassed to theexitevent - emit an
errorevent witherror.code: 'ETIMEDOUT'onchildProcess. This is a breaking change since many users are currently listening forerrorevents, so would probably not be a good idea. childProcess.timedOut = truechildProcess.timedOut()returning a boolean
What alternatives have you considered?
One could possibly set a manual timeout like the following.
let timedOut = false
setTimeout(() => {
timedOut = true
}, 2e3)
However, it defeats some of the convenience of the timeout option, since that one might as well call childProcess.kill() themselves then. Also, it is slightly unreliable since an unrelated SIGTERM could theoretically have been sent at the exact same time.
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从示例中展示的 child_process.spawn() 的 timeout 和 exit event 行为开始。审查针对 timeout event、exit metadata、error 和 properties 提出的方案,然后确定一种有文档说明的方式,使用户能够区分由 timeout 触发的终止和无关的 SIGTERM。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- javascript, node.js
- 领域
- api, backend
- Issue 类型
- 功能
- 难度
- 5/5
- 预计耗时
- 一周以上
- 活跃度
- 冷清
- 描述清晰度
- 需要澄清
- 新手友好度
- 45/100