Know when a process ended due to the `child_process.spawn()` `timeout` option
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- JavaScript
- Estrellas
- 122k
- Forks
- 37.3k
- Merge medio
- 4 d 2 h
- PR fusionados (30 d)
- 283
Descripción
What is the problem this feature will solve?
When a process ends due to the timeout option of child_process.spawn(), there is no way to know whether that termination was due to the timeout. A SIGTERM is sent to the process, but that's pretty much it.
import {spawn} from 'node:child_process'
const childProcess = spawn('node', ['-e', 'setTimeout(() => {}, 1e7)'], {
timeout: 2e3,
stdio: 'inherit', // no stdout/stderr
})
childProcess.on('exit', (exitCode, signal) => {
console.log({exitCode, signal}) // { exitCode: null, signal: 'SIGTERM' }
})
This makes debugging harder. Some users might be left wondering why the process ended if they don't pay attention to the timeout option.
What is the feature you are proposing to solve the problem?
Having a way to know whether the process ended due to the timeout option. Any implementation would work. Some potential ideas:
timeoutevent onchildProcess- third boolean argument
timedOutpassed to theexitevent - emit an
errorevent witherror.code: 'ETIMEDOUT'onchildProcess. This is a breaking change since many users are currently listening forerrorevents, so would probably not be a good idea. childProcess.timedOut = truechildProcess.timedOut()returning a boolean
What alternatives have you considered?
One could possibly set a manual timeout like the following.
let timedOut = false
setTimeout(() => {
timedOut = true
}, 2e3)
However, it defeats some of the convenience of the timeout option, since that one might as well call childProcess.kill() themselves then. Also, it is slightly unreliable since an unrelated SIGTERM could theoretically have been sent at the exact same time.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comience con el comportamiento de timeout y exit event de child_process.spawn() mostrado en el ejemplo. Revise los enfoques propuestos para timeout event, exit metadata, error y properties, y determine después una forma documentada para que los usuarios distingan una terminación provocada por timeout de un SIGTERM no relacionado.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- javascript, node.js
- Área
- api, backend
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Tranquilo
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 45/100