Under Windows, spawning a `pwsh` child process using `spawn` and `detached: true` does not work
Nessuno ha ancora preso questa issue.
- Lingua principale
- JavaScript
- Stelle
- 122k
- Fork
- 37.3k
- Merge medio
- 4g 2h
- PR unite (30g)
- 283
Descrizione
Version
v20.9.0
Platform
Microsoft Windows NT 10.0.22621.0 x64
Subsystem
child_process
What steps will reproduce the bug?
With this Node.js program:
import {spawn} from 'node:child_process';
const timer = `Running program`;
console.time(timer);
process.on('exit', () => console.timeEnd(timer));
const options = {
detached: true, stdio: 'ignore', // try commenting to see both sub processes work but not being detached
};
const procNode = spawn('node', ['test-detached.js'], options); procNode.unref(); // always works
const procPwsh = spawn('pwsh', ['-File', 'test-detached.ps1'], options); procPwsh.unref(); // fails when detached: true
and those files next to it:
test-detached.js
import {writeFile} from 'node:fs/promises';
import {setTimeout} from 'node:timers/promises';
await setTimeout(2000);
await writeFile('from-node.txt', 'Hello from Node.js');
test-detached.ps1
Start-Sleep -Seconds 2
'Hello from PowerShell (pwsh)' > ./from-pwsh.txt
You can see that when activating the detached option, only from-node.txt is generated (after 2 seconds), and the parent program indeed doesn't wait for the child processes to complete.
If you deactivate that option, you can see both files from-node.txt and from-pwsh.txt appear, but the parent process waits (around 2 seconds + overhead).
How often does it reproduce? Is there a required condition?
It always happens.
What is the expected behavior? Why is that the expected behavior?
The PowerShell execution should go through.
What do you see instead?
The PowerShell execution does not go through.
Additional information
I am a bit clueless here. Given the fact it works with node.exe but doesn't with pwsh.exe, it is clearly contextual.
Either Node.js should handle such cases automatically, or it should open its API more to allow fine tuning the spawn configuration to make such cases work. I am really wondering what PowerShell does/expects to have the process fail.
Note that according to one of the comments on this thread on StackOverflow, it seems to be an issue on Windows only. So maybe indeed a need to adjust the use of Windows APIs...
I may push my investigation further and post updates here. For instance I'll try the same test from Python. I'll also double check on Linux.
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
Inizia dal punto di ingresso child_process.spawn e riproduci il caso Windows con test-detached.js e test-detached.ps1 usando detached: true e stdio: 'ignore'. Confronta il processo figlio node funzionante con il processo figlio pwsh che non funziona e traccia la gestione dei processi scollegati in Windows. Il lavoro è completato quando pwsh viene eseguito in modo indipendente e crea from-pwsh.txt, mentre il processo padre termina senza attendere.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- javascript, node.js, powershell
- Ambito
- backend, operating-systems
- Tipo di issue
- Bug
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Stato di attività
- Tranquilla
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 45/100