nodejs / nodejs/node

https.get, https.request and both function calls with and without explicit URL arguments behave differently for same request options.

未关闭
#45,014 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

https
主要语言
JavaScript
星标
122k
派生
37.3k
平均合并
4 天 2 小时
30 天内合并 PR
283

描述

Version

v16.15.0

Platform

Darwin MBP-NSR 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 20:19:52 PDT 2022; root:xnu-8020.140.49~2/RELEASE_ARM64_T6000 arm64

Subsystem

No response

What steps will reproduce the bug?

run this script and toggle the comments on line 33 and 34 to first use request then use get
Also if you also toggle comments on line 35 you will see different behaviours

results from all four cases are provided ahead

const https = require("https")

const options = {
  headers: {
    "Cache-Control": "no-cache",
    "accept": "*/*",
    "accept-encoding": "gzip",
    "accept-language": "en-GB,en-US;q=0.9,en;q=0.8",
    "amiusingrequestly": "true",
    "cache-control": "no-cache",
    "connection": "keep-alive",
    "cookie": "test=abc",
    "host": "github.com",
    "pragma": "no-cache",
    "referer": "https://github.com/",
    "sec-ch-ua": "\"Chromium\";v=\"106\", \"Google Chrome\";v=\"106\", \"Not;A=Brand\";v=\"99\"",
    "sec-ch-ua-mobile": "?0",
    "sec-ch-ua-platform": "\"macOS\"",
    "sec-fetch-dest": "manifest",
    "sec-fetch-mode": "cors",
    "sec-fetch-site": "same-origin",
    "user-agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Safari/537.36",
  },
  method: "GET",
  rejectUnauthorized: false,
  requestCert: true,
  strictSSL: false,
  url: "https://httpbin.org/cookies",
}
async function main() {
  try{
    let output = await new Promise ((resolve, reject) => {
      // let req = https.get( // line 33
      let req = https.request(  // line 34
        // options.url, // line 35
        options,
        (res) => {
          let data = []
          res.on('data', (buffer) => {
            data.push(buffer)
          });
          res.on('end', () => {
            resolve({data: Buffer.concat(data).toString(), res})
          });
        }
      )
    req.on('error', (e) => {
      console.error(e);
      reject(e)
    });
    })
    console.log(output.data)
  } catch(e) { 
    console.error(e)
  }
}
main()
How often does it reproduce? Is there a required condition?

every time for the request options provided in the script.

What is the expected behavior?

Following the docs for requests and get seems like they should behave the same way for the same options. And if it works in one case (using get with explicit URL parameters), it should also work for the other cases.

What do you see instead?

when we use get in the above script everything works fine when URL is provided explicitly
in ever other case I either get this error

Error: connect ECONNREFUSED 127.0.0.1:443
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1187:16) {
  errno: -61,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 443
}
Error: connect ECONNREFUSED 127.0.0.1:443
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1187:16) {
  errno: -61,

  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 443
}

or the request just stalls in the case of request with url

screenshot as summary of the bug
error-demo

Additional information

I haven't tried to test this for any other case so not completely sure if this is a problem because of node/https or has something to do with the request options or the URL
Also haven't tried any other version of node.
Just stumbled into this and couldn't find a related issue so raising one now.

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

从 https.get 和 https.request 文档开始,运行提供的复现脚本,并切换第 33–35 行中的调用和显式 URL。使用相同的选项比较全部四种情况,包括观察到的连接错误和停滞。行为得到解释,并且相关调用形式能够一致地处理所提供的 request 选项,即表示完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript, node.js
领域
backend, networking
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
冷清
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。