nodejs / nodejs/core-validate-commit
signed-off-by: skip rule when PR-URL trailer is present not only Backport-PR-URL?
還沒有人認領這個 Issue。
- 主要語言
- JavaScript
- 星號
- 55
- 分支
- 62
- 平均合併
- 4 天 9 小時
- 30 天內合併 PR
- 1
描述
The signed-off-by rule currently skips backports identified by a Backport-PR-URL: trailer. This works for already-landed backport commits, but fails for backport PRs at review time because the commit-queue only adds Backport-PR-URL: at land time. even though the contributing doc explicitly exempts backports.
The lint (in core-validate-commit) says: if no Signed-off-by: AND no Backport-PR-URL: (which is added by the commit-queue), fail.
Suggestion
Treat PR-URL: trailer as the same kind of skip signal as Backport-PR-URL:. Both trailers are added by the commit-queue at land time they're never contributor-authored. Their presence on a commit being validated is a strong heuristic that the commit was either cherry-picked from a previously-landed PR (the dominant case, all backports), or is itself a previously-landed commit having its message re-validated.
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
從 core-validate-commit 中的 Signed-off-by 規則開始,追蹤其對 Backport-PR-URL: trailer 的現有處理方式。檢查驗證測試(如果有),並確認帶有 PR-URL: 的提交無需 Signed-off-by 即可接受,而其他提交仍保留目前的要求。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- javascript
- 領域
- tooling
- Issue 類型
- 缺陷
- 難度
- 2/5
- 預估耗時
- 1-3 小時
- 活躍度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 68/100