nodejs / nodejs/core-validate-commit

signed-off-by: skip rule when PR-URL trailer is present not only Backport-PR-URL?

未关闭 适合新手
#149 2 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

主要语言
JavaScript
星标
55
派生
62
平均合并
4 天 9 小时
30 天内合并 PR
1

描述

The signed-off-by rule currently skips backports identified by a Backport-PR-URL: trailer. This works for already-landed backport commits, but fails for backport PRs at review time because the commit-queue only adds Backport-PR-URL: at land time. even though the contributing doc explicitly exempts backports.

Rule 1 says:
https://github.com/nodejs/node/blob/e15f90559bc62b1e9a8296f1fc8654f5be261baa/doc/contributing/pull-requests.md?plain=1#L207-L208

Rule 2 says:
https://github.com/nodejs/node/blob/e15f90559bc62b1e9a8296f1fc8654f5be261baa/doc/contributing/backporting-to-release-lines.md?plain=1#L77

The lint (in core-validate-commit) says: if no Signed-off-by: AND no Backport-PR-URL: (which is added by the commit-queue), fail.

Suggestion

Treat PR-URL: trailer as the same kind of skip signal as Backport-PR-URL:. Both trailers are added by the commit-queue at land time they're never contributor-authored. Their presence on a commit being validated is a strong heuristic that the commit was either cherry-picked from a previously-landed PR (the dominant case, all backports), or is itself a previously-landed commit having its message re-validated.

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

从 core-validate-commit 中的 Signed-off-by 规则开始,跟踪其对 Backport-PR-URL: trailer 的现有处理方式。检查验证测试(如果有),并确认带有 PR-URL: 的提交无需 Signed-off-by 即可接受,而其他提交仍保留当前要求。

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript
领域
tooling
Issue 类型
缺陷
难度
2/5
预计耗时
1-3 小时
活跃度
冷清
描述清晰度
基本清楚
新手友好度
68/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。