nodeSolidServer / nodeSolidServer/node-solid-server
A member of a private group can't access a file shared with the group by other member
Chưa có ai nhận issue này.
- Ngôn ngữ chính
- JavaScript
- Star
- 1.8k
- Fork
- 308
- Chỉ số merge pull request
- Không có pull request nào được merge trong 30 ngày
Mô tả
By private group we mean a group defined in a file that has permission to be viewed by the group itself (detailed description follows).
The issue
When we
- set up three accounts on NSS (v5.7.2) (1, 2, 3),
- create a group on the first account, containing all three accounts, defined as follows
(a similar group, but public, is here),@prefix : <#>. @prefix vcard: <http://www.w3.org/2006/vcard/ns#>. @prefix p1: <https://grouptest1.solidcommunity.net/profile/card#me>. @prefix p2: <https://grouptest1.solidweb.org/profile/card#me>. @prefix p3: <https://grouptest2.solidcommunity.net/profile/card#me>. :group a vcard:Group; vcard:hasMember p1:, p2:, p3:. - give the group permission to view itself (i.e. set up .acl file for the group file as follows)
(Here we already have a major win, because group members can see the group. Compare to CSS, which currently fails at this task (https://github.com/CommunitySolidServer/CommunitySolidServer/issues/1442) 🎉),@prefix : <#>. @prefix acl: <http://www.w3.org/ns/auth/acl#>. @prefix c: </profile/card#>. @prefix priv: <private-group.ttl#>. :ControlReadWrite a acl:Authorization; acl:accessTo <private-group.ttl>; acl:agent c:me; acl:mode acl:Control, acl:Read, acl:Write. :Read a acl:Authorization; acl:accessTo <private-group.ttl>; acl:agentGroup priv:group; acl:mode acl:Read. - create a document on the second account
😄,@prefix : <https://example.com/>. :this :is :test. - give the group permission to view the document (i.e. set up .acl file for the document as follows)
(this step already failed with the SolidOS, we needed to set up the .acl manually),@prefix : <#>. @prefix acl: <http://www.w3.org/ns/auth/acl#>. @prefix c: </profile/card#>. @prefix priv: <https://grouptest1.solidcommunity.net/group-test/private-group.ttl#>. :ControlReadWrite a acl:Authorization; acl:accessTo <document-private-group-solidcommunity.ttl>; acl:agent c:me; acl:mode acl:Control, acl:Read, acl:Write. :Read a acl:Authorization; acl:accessTo <document-private-group-solidcommunity.ttl>; acl:agentGroup priv:group; acl:mode acl:Read. - and attempt to access the document with the third account,
it fails with 403 Forbidden.
Expected result
A member of a private group (i.e. a group viewable by itself) can read documents that other members share with the group.
Context and motivation
This bugfix/feature is a necessary step towards fully functional private groups on Solid. E.g. there are non-public Solid groups, and members of the groups can share (sensitive) data with other group members only.
We stumbled upon this issue when developing a hospitality exchange based on Solid (WIP).
Hướng dẫn đóng góp
Bắt đầu từ đâu
- Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
- Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
- Fork repository và làm thay đổi trên một nhánh.
- Mở pull request có tham chiếu số hiệu của issue.
Hướng nghiên cứu
Start by reproducing the 403 using the private-group.ttl and document-private-group-solidcommunity.ttl ACL examples described in the issue, including access as the third account. Trace how the server resolves private group membership across the referenced resources; done means a group member can read the shared document without weakening access for non-members.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Công nghệ
- javascript
- Lĩnh vực
- authorization
- Loại issue
- Lỗi
- Độ khó
- 4/5
- Thời gian dự kiến
- 3-5 ngày
- Mức độ hoạt động
- Đình trệ
- Độ rõ ràng
- Khá rõ ràng
- Mức phù hợp với người mới
- 35/100