nodeSolidServer / nodeSolidServer/node-solid-server
Don't rely on existence of /profile/card to block sign-up.
@jaxoncreed 已經在處理了。
開始於 2019年12月10日。
- 主要語言
- JavaScript
- 星號
- 1.8k
- 分支
- 308
- PR 合併指標
- 30 天內沒有已合併 PR
描述
In single-user mode, you can register once.
If you try to register a second time, https://github.com/solid/node-solid-server/blob/master/lib/models/account-manager.js#L111 will notice that ./data/profile/card$.ttl already exists, and respond with a 400.
However, if you manually delete that file, then that means that if someone goes to the Register page, they can take over control of your pod.
For multi-user mode, this would presumably work too, but then you need to "guess" the username for which the profile doc is missing, so it's less likely to occur.
We could change the check for user existence, for instance, (also) check if an oidc user exists, or if a data folder exists at all.
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
評估
這個 Issue 還沒有評估資料。