nodeSolidServer / nodeSolidServer/node-solid-server
Don't rely on existence of /profile/card to block sign-up.
@jaxoncreed 已经在做这个了。
开始于 2019年12月10日。
- 主要语言
- JavaScript
- 星标
- 1.8k
- 派生
- 308
- PR 合并指标
- 30 天内没有已合并 PR
描述
In single-user mode, you can register once.
If you try to register a second time, https://github.com/solid/node-solid-server/blob/master/lib/models/account-manager.js#L111 will notice that ./data/profile/card$.ttl already exists, and respond with a 400.
However, if you manually delete that file, then that means that if someone goes to the Register page, they can take over control of your pod.
For multi-user mode, this would presumably work too, but then you need to "guess" the username for which the profile doc is missing, so it's less likely to occur.
We could change the check for user existence, for instance, (also) check if an oidc user exists, or if a data folder exists at all.
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
评估
这个 Issue 还没有评估数据。