nodeSolidServer / nodeSolidServer/node-solid-server

Attempting to log in with a corrupted pod doesn't fail nicely

Abierto
#1,347 0 comentarios 0 reacciones 1 asignado Ver en GitHub

@jaxoncreed ya está trabajando en esto.

Desde el 10/11/2019.

Lenguaje dominante
JavaScript
Estrellas
1.8k
Forks
308
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

I currently have a pod that is corrupted (intentionally) for testing, the card file has invalid ttl in it. When trying to log in with this user in an app (for example, https://generator.inrupt.com) the provider login page is shown and requests are made. One request remains pending, and the /login screen is frozen on a blank page, no loading, no error, no indication of what happened.

The request that is perma-pending is:

https://solid.community/sharing?response_type=id_token%20token&display=&scope=openid&client_id=7243feb745e3e4b7290dea824279a6b3&redirect_uri=https%3A%2F%2Flocalhost%3A3000%2Fwelcome&state=54astYEpyO7A5peWgpiYGamznrW0Zy-6Aidnm_3PIn8&nonce=&request=<token>

It would be nice if we could show an error on the screen and indicate that something has gone wrong, maybe even point people a little bit towards the resolution of the issue.

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.