nodeSolidServer / nodeSolidServer/node-solid-server
Attempting to log in with a corrupted pod doesn't fail nicely
@jaxoncreed is already working on this.
Since Nov 10, 2019.
- Dominant language
- JavaScript
- Stars
- 1.8k
- Forks
- 308
- PR merge metrics
- No merged PRs in 30d
Description
I currently have a pod that is corrupted (intentionally) for testing, the card file has invalid ttl in it. When trying to log in with this user in an app (for example, https://generator.inrupt.com) the provider login page is shown and requests are made. One request remains pending, and the /login screen is frozen on a blank page, no loading, no error, no indication of what happened.
The request that is perma-pending is:
https://solid.community/sharing?response_type=id_token%20token&display=&scope=openid&client_id=7243feb745e3e4b7290dea824279a6b3&redirect_uri=https%3A%2F%2Flocalhost%3A3000%2Fwelcome&state=54astYEpyO7A5peWgpiYGamznrW0Zy-6Aidnm_3PIn8&nonce=&request=<token>
It would be nice if we could show an error on the screen and indicate that something has gone wrong, maybe even point people a little bit towards the resolution of the issue.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.