nodeSolidServer / nodeSolidServer/node-solid-server

Requesting index.html from root will serve the data browser, not the file itself

未关闭
#1,345 3 条评论 4 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

bug regression
主要语言
JavaScript
星标
1.8k
派生
308
PR 合并指标
30 天内没有已合并 PR

描述

Based on https://github.com/solid/userguide/pull/7 I became aware that if you request index.html from the root of a storage, it will return the HTML for the data browser instead of the index.html file itself.

E.g. https://megoth.solid.community/ will give another response than https://megoth.solid.community/index.html. The latter is a handy bug for people who want to edit the index.html file though, so before fixing this bug we need to make sure that users have the ability to edit index.html via the data browser using other means.

With the fix in https://github.com/solid/node-solid-server/pull/1341 we do get this feature though, as users can fetch the contents of index.html through "Your stuff" in the Dashboard. This paves the way for a fix for this bug, which would result in the correct HTML being returned, which is also good for the Source, which will show the correct HTML instead of the default HTML for the data browser.

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

审查 node-solid-server pull request 1341 以及对存储根目录和 /index.html 的请求处理。确认用户仍可通过 Dashboard 中的 Your stuff 获取 index.html,然后验证根目录请求和 Source 显示的是文件的 HTML,而不是数据浏览器的 HTML。

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript, nodejs
领域
backend
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。