nodeSolidServer / nodeSolidServer/node-solid-server

Requesting index.html from root will serve the data browser, not the file itself

Open
#1,345 3 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug regression
Dominant language
JavaScript
Stars
1.8k
Forks
308
PR merge metrics
No merged PRs in 30d

Description

Based on https://github.com/solid/userguide/pull/7 I became aware that if you request index.html from the root of a storage, it will return the HTML for the data browser instead of the index.html file itself.

E.g. https://megoth.solid.community/ will give another response than https://megoth.solid.community/index.html. The latter is a handy bug for people who want to edit the index.html file though, so before fixing this bug we need to make sure that users have the ability to edit index.html via the data browser using other means.

With the fix in https://github.com/solid/node-solid-server/pull/1341 we do get this feature though, as users can fetch the contents of index.html through "Your stuff" in the Dashboard. This paves the way for a fix for this bug, which would result in the correct HTML being returned, which is also good for the Source, which will show the correct HTML instead of the default HTML for the data browser.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review node-solid-server pull request 1341 and the handling of requests for the storage root and /index.html. Confirm that users can still fetch index.html through Your stuff in the Dashboard, then verify that the root request and Source show the file's HTML rather than the data browser HTML.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, nodejs
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.