modelstudioai / modelstudioai/cli
[bug]: bl skill init / skill remove ignore --dry-run and perform real changes
まだ誰も着手していません。
- 主要言語
- TypeScript
- スター
- 333
- フォーク
- 28
- 平均マージ
- 1日 9時間
- マージ済み PR(30日)
- 33
説明
Environment
- CLI: bl 1.26.0 (npm install; upgraded from 1.3.2 via
bl updatetoday) - Skill: 1.26.0 (
bailian-cli, installed bybl skill init) - Node: v22.22.2
- OS: darwin 25.6.0 (macOS)
- Region: cn
Summary
--dry-run is listed under "Global Flags" in bl skill init --help, bl skill remove --help (and add / update), but the whole skill command group ignores it: bl skill init --dry-run performed a full real installation (10 skills fanned out into 56 agent directories), and bl skill remove --name <x> --dry-run really deleted the skill. Exit code 0 in both cases.
Reproduce
# 1. "Preview" what init would do -> actually installs everything
bl skill init --dry-run
# 2. "Preview" a removal -> actually removes it
bl skill remove --name bailian-web-search --dry-run
Expected
With --dry-run, nothing is written or deleted; the command prints the plan (skills, target agent directories, link paths). Alternatively, if dry-run is not supported for these commands, the flag is rejected with a USAGE error and not advertised in their --help.
Actual
bl skill init --dry-run printed:
{
"status": "success",
"skills": [
"bailian-cli", "bailian-finetune", "bailian-gen", "bailian-managed-agent",
"bailian-protocol", "bailian-sandbox", "bailian-web-search",
"bailian-docs-llm-wiki", "bailian-model-recommend", "bailian-train-deploy"
]
}
and on disk, all within the same second:
~/.bailian/skills/<10 skills>/were created (~33 MB, mostlybailian-docs-llm-wiki) and~/.bailian/skills/skill-lock.jsonwas written.- Symlinks were fanned out into 56 detected agent skill directories (
~/.claude/skills,~/.agents/skills,~/.codex/skills,~/.gemini/skills, ...). - The pre-existing real directory
~/.agents/skills/bailian-cli(installed from GitHub vianpx skills add modelstudioai/cliand refreshed bybl updatea few minutes earlier) was replaced by a symlink to~/.bailian/skills/bailian-cli. I did not find a backup of the replaced directory. ~/.bailian/telemetry.jsonlrecorded a plain{"command":"skill init", ..., "params":{}}entry with no dry-run marker.
bl skill remove --name bailian-web-search --dry-run printed:
{
"skills": [
{ "name": "bailian-web-search", "status": "removed", "removedLinks": 56 }
]
}
and the canonical directory plus all 56 links were really gone; a subsequent real bl skill remove --name bailian-web-search reported "reason": "not installed".
Likely cause
At HEAD, packages/commands/src/commands/skill/{init,add,remove,update,list}.ts never read ctx.settings.dryRun (there is no occurrence of dryRun anywhere under skill/). init.ts calls installSkillWithFanout(...) unconditionally and remove.ts calls unlinkSkillFromAgents(...) / removeSkillDir(...) unconditionally, while the global --dry-run flag is still rendered in every bl skill ... --help.
Why it matters
--dry-runis the documented way for agents to preview a mutating command before asking the user for consent (bailian-protocol). Here it silently performs the mutation, so an agent that follows the protocol ends up installing 10 skills into every detected agent app on the machine, which also changes default routing in those agents (e.g.bailian-gen/bailian-web-searchclaim generation / search requests by default).bl update(npm path) and the automatic update check both runbl skill initafterwards (see also #200), so there is currently no non-mutating way to see what a skill install/update is going to write.
Suggested fix
Either honor dryRun in the skill group (print planned installs/removals with target agent directories and link paths, write nothing), or make these commands reject --dry-run with a USAGE error and drop it from their --help so it cannot be mistaken for a safe preview.
Already tried
-
bl updatedone today; skill version (1.26.0) aligned with CLI (1.26.0) -
bl auth statusOK (not relevant:skillcommands are[No Auth]) - Different network / region: not applicable, purely local operation
Notes
- Frequency: Always (reproduced with both
skill initandskill remove) - Invoked via: Agent (Claude Code)
- Registry:
https://bailian-wiki.oss-cn-hangzhou.aliyuncs.com/skills
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
packages/commands/src/commands/skill/{init,add,remove,update,list}.ts から始め、ctx.settings.dryRun が skill コマンドにどのように渡るかを調べます。init.ts を installSkillWithFanout まで、remove.ts を unlinkSkillFromAgents と removeSkillDir まで追跡し、その後、文書化されている init と remove の再現手順を実行します。dry-run が書き込み、削除、リンクの作成を行わずに計画を表示するか、拒否されてヘルプに表示されなければ完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- typescript
- 領域
- cli
- issue の種類
- バグ
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 活発さ
- 活発
- 明瞭さ
- 明確に書かれている
- 初心者へのやさしさ
- 72/100