modelcontextprotocol / modelcontextprotocol/python-sdk

Generated output schema uses Pydantic's validation shape while structured output uses its serialization shape

Aperta
#3,100 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

bug needs confirmation P2 v1 v2
Lingua principale
Python
Stelle
24.3k
Fork
4k
Merge medio
1g 1h
PR unite (30g)
31

Descrizione

Initial Checks
  • I confirm that I'm using the latest version of MCP Python SDK.
  • I confirm that I searched existing issues and pull requests before opening this issue.
Description

For a Pydantic return model whose validation and serialization shapes differ, the generated outputSchema describes the validation shape while structuredContent uses the serialization shape. The SDK therefore publishes an output schema that rejects its own generated structured result.

This is related to, but not a duplicate of, #1073 / #1099. That change aligned ordinary field aliases by serializing structured output with aliases. Split validation_alias / serialization_alias values still expose different validation and serialization shapes, and serialization-only fields such as computed_field reveal the same underlying mismatch.

Example Code
from __future__ import annotations

import asyncio
import json

from jsonschema import Draft202012Validator
from pydantic import BaseModel, ConfigDict, Field, computed_field

try:
    from mcp.server.mcpserver.tools.base import Tool
except ImportError:  # MCP Python SDK 1.x
    from mcp.server.fastmcp.tools.base import Tool


class AliasOutput(BaseModel):
    model_config = ConfigDict(extra="forbid", populate_by_name=True)
    value: int = Field(validation_alias="wireIn", serialization_alias="wireOut")


def alias_output() -> AliasOutput:
    return AliasOutput(value=1)


class ComputedOutput(BaseModel):
    model_config = ConfigDict(extra="forbid")
    value: int

    @computed_field
    @property
    def doubled(self) -> int:
        return self.value * 2


def computed_output() -> ComputedOutput:
    return ComputedOutput(value=1)


async def check(function: object) -> None:
    tool = Tool.from_function(function)
    converted = await tool.run({}, None, convert_result=True)
    structured = converted[1] if isinstance(converted, tuple) else converted.structured_content
    errors = [
        error.message
        for error in Draft202012Validator(tool.output_schema).iter_errors(structured)
    ]
    print(function.__name__)
    print("schema:", json.dumps(tool.output_schema, sort_keys=True))
    print("structured:", json.dumps(structured, sort_keys=True))
    print("schema_errors:", errors)


async def main() -> None:
    await check(alias_output)
    await check(computed_output)


asyncio.run(main())

Observed validator messages:

alias_output
schema: ... "wireIn" ...
structured: {"wireOut": 1}
schema_errors: ["Additional properties are not allowed ('wireOut' was unexpected)", "'wireIn' is a required property"]

computed_output
schema: ... "value" ...
structured: {"doubled": 2, "value": 1}
schema_errors: ["Additional properties are not allowed ('doubled' was unexpected)"]
Expected behavior

The generated outputSchema should describe the serialized structured output. Generating the output model schema in Pydantic serialization mode makes both witnesses conform: the alias schema uses wireOut, and the computed-field schema includes doubled.

Python & MCP Python SDK
  • Python: 3.13.13
  • MCP Python SDK: 1.28.1 (latest stable)
  • Also reproduced on current main: 2713b53b127afc094dc97d6067df9f69b647661c (2.0.0b2)
  • Pydantic: 2.13.4

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia da Tool.from_function nell’implementazione degli strumenti del server MCP, usando i percorsi di importazione mostrati per le versioni dell’SDK, e traccia come vengono prodotti output_schema e structured_content. Riproduci gli esempi alias_output e computed_output con Draft202012Validator. Il lavoro è completato quando lo schema generato accetta entrambi i risultati strutturati serializzati, inclusi wireOut e doubled.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
python
Ambito
api, backend
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Tranquilla
Chiarezza
Specificata chiaramente
Idoneità per principianti
52/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.