modelcontextprotocol / modelcontextprotocol/python-sdk
McpError is not pickle-safe and fails to unpickle
还没有人认领这个 Issue。
- 主要语言
- Python
- 星标
- 24.3k
- 派生
- 4k
- 平均合并
- 1 天 1 小时
- 30 天内合并 PR
- 31
描述
Initial Checks
- I confirm that I'm using the latest version of MCP Python SDK
- I confirm that I searched for my issue in https://github.com/modelcontextprotocol/python-sdk/issues before opening this issue
Description
Summary
mcp.shared.exceptions.McpError does not survive a normal cloudpickle.dumps() / cloudpickle.loads() round-trip.
The failure appears to come from McpError.__init__ expecting an ErrorData object, while exception unpickling reconstructs it with a plain string from Exception.args.
This is surfacing for us through background task execution, but the bug reproduces without Docket/FastMCP task machinery.
Actual behavior
Unpickling fails with:
AttributeError: 'str' object has no attribute 'message'
Traceback points at McpError.__init__:
class McpError(Exception):
error: ErrorData
def __init__(self, error: ErrorData):
super().__init__(error.message)
self.error = error
Expected behavior
McpError(ErrorData(...)) should round-trip through pickle/cloudpickle without crashing.
At minimum, this should work:
- serialize
McpError - deserialize
McpError - preserve the message
- preserve the
errorpayload, or at least degrade safely without raising during unpickle
Suspected root cause
McpError stores error.message in Exception.args via super().__init__(error.message).
On unpickle, exception reconstruction uses args, so McpError is effectively reconstructed as:
McpError("Authentication Required")
But McpError.__init__ assumes error is always an ErrorData, so it does:
error.message
which crashes for str.
Suggested fix
McpError likely needs to be pickle-safe by design. Any of these would probably fix it:
- Make
__init__accept bothErrorDataandstr, normalizingstrinto anErrorData. - Implement
__reduce__so pickle reconstructs using the fullErrorData. - Ensure constructor args and exception state are aligned with standard exception pickling behavior.
A robust version would probably do both __reduce__ and tolerant initialization.
Notes
This bug is easy to misattribute to cloudpickle or task runners, but the reproducer above shows it is local to McpError itself.
Example Code
from importlib.metadata import version
import cloudpickle
from mcp.shared.exceptions import McpError
from mcp.types import ErrorData
print("Versions:")
print(f" mcp={version('mcp')}")
print(f" cloudpickle={version('cloudpickle')}")
original = McpError(ErrorData(code=-32600, message="Authentication Required"))
print("\nOriginal exception:")
print(f" type={type(original).__name__}")
print(f" str={str(original)!r}")
print(f" error_type={type(original.error).__name__}")
print(f" error_message={original.error.message!r}")
payload = cloudpickle.dumps(original)
print("\nUnpickling:")
restored = cloudpickle.loads(payload)
print(f" restored_type={type(restored).__name__}")
print(f" restored_args={restored.args!r}")
print(f" restored_error={getattr(restored, 'error', None)!r}")
Python & MCP Python SDK
- `mcp==1.26.0`
- `fastmcp==3.2.3`
- `cloudpickle==3.1.2`
- Python 3.13
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 mcp.shared.exceptions 中的 McpError 开始,使用提供的 cloudpickle 示例重现该失败。检查 Exception.args 如何在反序列化期间重建异常,然后验证 McpError 的往返过程是否保留其消息和错误负载,或在不引发异常的情况下降级。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- python
- 领域
- backend
- Issue 类型
- 缺陷
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 活跃度
- 活跃
- 描述清晰度
- 基本清楚
- 新手友好度
- 74/100