modelcontextprotocol / modelcontextprotocol/python-sdk
McpError is not pickle-safe and fails to unpickle
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Python
- Estrellas
- 24.3k
- Forks
- 4k
- Merge medio
- 1 d 1 h
- PR fusionados (30 d)
- 31
Descripción
Initial Checks
- I confirm that I'm using the latest version of MCP Python SDK
- I confirm that I searched for my issue in https://github.com/modelcontextprotocol/python-sdk/issues before opening this issue
Description
Summary
mcp.shared.exceptions.McpError does not survive a normal cloudpickle.dumps() / cloudpickle.loads() round-trip.
The failure appears to come from McpError.__init__ expecting an ErrorData object, while exception unpickling reconstructs it with a plain string from Exception.args.
This is surfacing for us through background task execution, but the bug reproduces without Docket/FastMCP task machinery.
Actual behavior
Unpickling fails with:
AttributeError: 'str' object has no attribute 'message'
Traceback points at McpError.__init__:
class McpError(Exception):
error: ErrorData
def __init__(self, error: ErrorData):
super().__init__(error.message)
self.error = error
Expected behavior
McpError(ErrorData(...)) should round-trip through pickle/cloudpickle without crashing.
At minimum, this should work:
- serialize
McpError - deserialize
McpError - preserve the message
- preserve the
errorpayload, or at least degrade safely without raising during unpickle
Suspected root cause
McpError stores error.message in Exception.args via super().__init__(error.message).
On unpickle, exception reconstruction uses args, so McpError is effectively reconstructed as:
McpError("Authentication Required")
But McpError.__init__ assumes error is always an ErrorData, so it does:
error.message
which crashes for str.
Suggested fix
McpError likely needs to be pickle-safe by design. Any of these would probably fix it:
- Make
__init__accept bothErrorDataandstr, normalizingstrinto anErrorData. - Implement
__reduce__so pickle reconstructs using the fullErrorData. - Ensure constructor args and exception state are aligned with standard exception pickling behavior.
A robust version would probably do both __reduce__ and tolerant initialization.
Notes
This bug is easy to misattribute to cloudpickle or task runners, but the reproducer above shows it is local to McpError itself.
Example Code
from importlib.metadata import version
import cloudpickle
from mcp.shared.exceptions import McpError
from mcp.types import ErrorData
print("Versions:")
print(f" mcp={version('mcp')}")
print(f" cloudpickle={version('cloudpickle')}")
original = McpError(ErrorData(code=-32600, message="Authentication Required"))
print("\nOriginal exception:")
print(f" type={type(original).__name__}")
print(f" str={str(original)!r}")
print(f" error_type={type(original.error).__name__}")
print(f" error_message={original.error.message!r}")
payload = cloudpickle.dumps(original)
print("\nUnpickling:")
restored = cloudpickle.loads(payload)
print(f" restored_type={type(restored).__name__}")
print(f" restored_args={restored.args!r}")
print(f" restored_error={getattr(restored, 'error', None)!r}")
Python & MCP Python SDK
- `mcp==1.26.0`
- `fastmcp==3.2.3`
- `cloudpickle==3.1.2`
- Python 3.13
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Empieza en McpError en mcp.shared.exceptions y reproduce el fallo con el ejemplo de cloudpickle proporcionado. Comprueba cómo Exception.args reconstruye la excepción durante la deserialización, y verifica después que un round-trip de McpError conserva su mensaje y su payload de error o se degrada sin lanzar una excepción.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- backend
- Tipo de issue
- Error
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Estado de actividad
- Activo
- Claridad
- Bastante claro
- Aptitud para principiantes
- 74/100