modelcontextprotocol / modelcontextprotocol/python-sdk
Trailing slash in OAuthMetadata's `issuer` causes issues with clients
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 24.3k
- 分支
- 4k
- 平均合併
- 1 天 1 小時
- 30 天內合併 PR
- 31
描述
Initial Checks
- I confirm that I'm using the latest version of MCP Python SDK
- I confirm that I searched for my issue in https://github.com/modelcontextprotocol/python-sdk/issues before opening this issue
Description
In the .well-known/oauth-authorization-server endpoint and , the issuer is forced to always contain a trailing slash e.g.,
https://your-mcp.com/instead ofhttps://your-mcp.com
as a byproduct of using pydantic'sAnyHttpUrltype.
This causes issues in both Google's ADK and IBM's MCP Context Forge because:
- when building the .well-known URL, they expect a discovery issuer URL that does not contain a trailing slash; and
- then they MUST verify that the returned metadata issuer URL is identical to the discovery issuer URL ("authorization server's issuer identifier value" in the spec) according to RFC 8414 Section 3.2; so
- when
OAuthMetadata.issuercontains the trailing slash, the discovery process is aborted.
OAuth 2.0 Authorization Server Metadata spec says that the client MUST remove trailing paths from when the issuer contains a path component:
If the issuer identifier value contains a path component, any
terminating "/" MUST be removed before inserting "/.well-known/" and
the well-known URI suffix between the host component and the path
component.
-- https://datatracker.ietf.org/doc/html/rfc8414#section-3.1
if the trailing / in https://example.com/ is a "path component", and should thus be stripped by the client, so I think the spec is ambiguous about the responsibilities of the client in the case where there the issuer identifier value contains a lone trailing slash.
I did note that the examples of issuer identifiers in the spec do not contain a lone trailing slash, i.e. they are https://example.com rather than https://example.com/.
For these reasons, and
- while it's listed as the client's responsibility to remove trailing slashes from the issuer identifier,
- I don't believe it's the server implementation's responsibility to intentionally make it harder for clients by returning a URL that do not follow the assumptions in the spec.
I think it's worth it to consider interpreting the spec as "the issuer field should not contain a trailing slash".
I also believe this issue could be similar in mechanism, but different in scope, to what is described in https://github.com/modelcontextprotocol/python-sdk/issues/1265
Example Code
# A demonstration on how AnyHttpUrl adds a trailing slash.
>>> from pydantic.networks import AnyHttpUrl
>>> x = AnyHttpUrl("http://localhost:8000")
>>> x
AnyHttpUrl('http://localhost:8000/')
>>> str(x)
'http://localhost:8000/'
>>>
Python & MCP Python SDK
Python 3.14
mcp==1.25.0
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
從 OAuthMetadata 模型和 .well-known/oauth-authorization-server 端點開始,然後檢查 Pydantic 的 AnyHttpUrl 如何正規化 issuer 值。在決定單一結尾斜線的預期處理方式之前,檢查 RFC 8414 的要求和現有 issue 討論;當返回的 issuer 和 discovery URL 仍與受影響的用戶端相容時,即表示完成。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- python
- 領域
- api, authentication
- Issue 類型
- 缺陷
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 活躍度
- 活躍
- 描述清晰度
- 基本清楚
- 新手友好度
- 58/100