modelcontextprotocol / modelcontextprotocol/python-sdk
Trailing slash in OAuthMetadata's `issuer` causes issues with clients
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Python
- Estrellas
- 24.3k
- Forks
- 4k
- Merge medio
- 1 d 1 h
- PR fusionados (30 d)
- 31
Descripción
Initial Checks
- I confirm that I'm using the latest version of MCP Python SDK
- I confirm that I searched for my issue in https://github.com/modelcontextprotocol/python-sdk/issues before opening this issue
Description
In the .well-known/oauth-authorization-server endpoint and , the issuer is forced to always contain a trailing slash e.g.,
https://your-mcp.com/instead ofhttps://your-mcp.com
as a byproduct of using pydantic'sAnyHttpUrltype.
This causes issues in both Google's ADK and IBM's MCP Context Forge because:
- when building the .well-known URL, they expect a discovery issuer URL that does not contain a trailing slash; and
- then they MUST verify that the returned metadata issuer URL is identical to the discovery issuer URL ("authorization server's issuer identifier value" in the spec) according to RFC 8414 Section 3.2; so
- when
OAuthMetadata.issuercontains the trailing slash, the discovery process is aborted.
OAuth 2.0 Authorization Server Metadata spec says that the client MUST remove trailing paths from when the issuer contains a path component:
If the issuer identifier value contains a path component, any
terminating "/" MUST be removed before inserting "/.well-known/" and
the well-known URI suffix between the host component and the path
component.
-- https://datatracker.ietf.org/doc/html/rfc8414#section-3.1
if the trailing / in https://example.com/ is a "path component", and should thus be stripped by the client, so I think the spec is ambiguous about the responsibilities of the client in the case where there the issuer identifier value contains a lone trailing slash.
I did note that the examples of issuer identifiers in the spec do not contain a lone trailing slash, i.e. they are https://example.com rather than https://example.com/.
For these reasons, and
- while it's listed as the client's responsibility to remove trailing slashes from the issuer identifier,
- I don't believe it's the server implementation's responsibility to intentionally make it harder for clients by returning a URL that do not follow the assumptions in the spec.
I think it's worth it to consider interpreting the spec as "the issuer field should not contain a trailing slash".
I also believe this issue could be similar in mechanism, but different in scope, to what is described in https://github.com/modelcontextprotocol/python-sdk/issues/1265
Example Code
# A demonstration on how AnyHttpUrl adds a trailing slash.
>>> from pydantic.networks import AnyHttpUrl
>>> x = AnyHttpUrl("http://localhost:8000")
>>> x
AnyHttpUrl('http://localhost:8000/')
>>> str(x)
'http://localhost:8000/'
>>>
Python & MCP Python SDK
Python 3.14
mcp==1.25.0
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza por el modelo OAuthMetadata y el endpoint .well-known/oauth-authorization-server; después, inspecciona cómo AnyHttpUrl de Pydantic normaliza el valor de issuer. Comprueba los requisitos de RFC 8414 y la discusión existente de la issue antes de decidir el comportamiento esperado de una única barra final; se considera terminado cuando el issuer devuelto y la URL de discovery siguen siendo compatibles con los clientes afectados.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- api, authentication
- Tipo de issue
- Error
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Activo
- Claridad
- Bastante claro
- Aptitud para principiantes
- 58/100