modelcontextprotocol / modelcontextprotocol/java-sdk
StdioClientTransport: Inbound Scheduler and Error Scheduler threads are locked on Windows
還沒有人認領這個 Issue。
- 主要語言
- Java
- 星號
- 3.7k
- 分支
- 1.1k
- 平均合併
- 1 天 15 小時
- 30 天內合併 PR
- 9
描述
Bug description
Two threads, Inbound Scheduler and Error Scheduler, remain locked forever (at java.io.FileInputStream.readBytes native call) in io.modelcontextprotocol.client.transport.StdioClientTransport after the graceful shutdown is completed using closeGracefully method.
Looks like a Windows specific issue with native I/O calls. The problem is observed when running on Windows. No problems with Linux environment.
The thread dump is attached.
dump_jdk17.txt
See "pool-2-thread-1" and "pool-5-thread-1" dumps.
Environment
Windows 11 Enterprise
mcp-core 0.17.1
Spring AI 2.0.0-SNAPSHOT
JDK Temurin 17.0.14 (also tried Amazon Corretto 21.0.5)
Linux Behavior
Works fine under Ubuntu 24.04 and JDK Temurin 21.0.10
Steps to reproduce
- Run the steps from the Spring AI Filesystem Demo example on Windows.
- The Java application process is not terminated as expected.
Expected behavior
The Java process terminates after running the Spring AI Filesystem Demo example.
Possible solution
On Windows, use daemon threads for inbound and error schedulers
private ThreadFactory daemonThreadFactory = runnable -> {
Thread t = new Thread(runnable);
t.setDaemon(true);
return t;
};
if (isWindows) {
this.inboundScheduler = Schedulers.fromExecutorService(Executors.newSingleThreadExecutor(daemonThreadFactory), "inbound");
this.errorScheduler = Schedulers.fromExecutorService(Executors.newSingleThreadExecutor(daemonThreadFactory), "error");
}
Tried this solution locally. It resolves the termination issue. But the graceful shutdown logic in io.modelcontextprotocol.client.transport.StdioClientTransport#closeGracefully should be revised as well.
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
從 io.modelcontextprotocol.client.transport.StdioClientTransport 開始,重點關注 Inbound Scheduler、Error Scheduler 和 closeGracefully 方法,然後檢查隨附的 Windows 執行緒傾印,以找出遭到阻塞的讀取操作。在 Windows 上重現 Spring AI Filesystem Demo,並驗證關閉作業會終止 Java 程序,而不會留下遭鎖定的 scheduler 執行緒。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- java
- 領域
- backend
- Issue 類型
- 缺陷
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 活躍度
- 停滯
- 描述清晰度
- 基本清楚
- 新手友好度
- 38/100