microsoftgraph / microsoftgraph/msgraph-sdk-java
members subresource is missing under directoryRolesWithRoleTemplateId in 6.5.1
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 444
- Forks
- 154
- Avg merge
- 18h 28m
- Merged PRs (30d)
- 4
Description
The Graph API supports listing members of a DirectoryRole via both its role-id and its roleTemplateId, like can be seen here: https://learn.microsoft.com/en-us/graph/api/directoryrole-list-members?view=graph-rest-1.0&tabs=http#http-request
In the new SDK, this would translate to these two statements:
client.directoryRoles().byDirectoryRoleId("roleId").members().get()
client.directoryRolesWithRoleTemplateId("roleTemplateId").members().get()
Of these, the first works fine, but the second is missing. DirectoryRolesWithRoleTemplateIdRequestBuilder does not have a members() method. In the Graph API, both constructs should behave identical, both for querying and manipulation (for example adding new members). The absence of this method forces us to split the call in two: first get the directory role by template id and then perform the actual operation.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with DirectoryRolesWithRoleTemplateIdRequestBuilder and compare it with the working directoryRoles().byDirectoryRoleId("roleId") builder. Trace how members() is exposed for the role-id path, then verify that the template-id path supports the same querying and member-manipulation operations. Done means client.directoryRolesWithRoleTemplateId("roleTemplateId").members().get() and the corresponding operations are available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100