microsoft / microsoft/vscode-python-debugger
Add configuration option to issue a SIGTERM when the Stop button is clicked in debugger
@karthiknadig y travaille déjà.
Depuis le 8/8/2024.
- Langage dominant
- TypeScript
- Étoiles
- 181
- Forks
- 126
- Merge moyen
- 2 j 3 h
- PR mergées (30 j)
- 3
Description
I want the ability to use the "Stop" button in the Python debugger in VS Code to send a SIGTERM (and/or maybe a SIGINT) to the running process, instead of just sending it SIGKILL (as it currently does).
This is the "Stop" button I'm talking about:
Proposed Solution
I'm thinking that a new option like this in the launch.json config file could be a good way to introduce this change without being a breaking change for the way everyone is used to the "stop" button working.
{
"configurations": [
{
"name": "Python Debugger: Current File (Integrated Terminal)",
"type": "debugpy",
"request": "launch",
"program": "${file}",
"console": "integratedTerminal",
"stop_action": "SIGKILL", // this would be a new enum-like config option, with values of "SIGKILL", "SIGINT", "SIGTERM", maybe others
},
]
}
Possible additional ideas, more context
-
The minimum viable solution is described above.
-
SIGKILL (the current behavior) and SIGTERM are the two behaviors I'm personally chasing. SIGINT is another one that would be good to have as an option though.
-
As an extended implementation, the
stop_actionfield could support a process like: send SIGTERM, wait 15 seconds, send SIGKILL. -
This feature request stems from wanting to be able to test and debug the AWS Batch end-of-job behavior:
Under the hood, the Amazon ECS StopTask API call is used, which sends a
SIGTERMvalue to the running container task. If after 30 seconds the container is still running, aSIGKILLsignal is sent to forcibly stop the container. If the container handles theSIGTERMvalue gracefully and exits within 30 seconds from receiving it, noSIGKILLvalue is sent.
Related Previous Issues and Discussions
- microsoft/vscode-python#21605
- https://github.com/microsoft/debugpy/issues/500
- https://github.com/microsoft/vscode-python/discussions/21582
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Évaluation
Cette issue n'a pas encore été évaluée.