microsoft / microsoft/vscode-python-debugger

Add configuration option to issue a SIGTERM when the Stop button is clicked in debugger

Offen
#316 10 Kommentare 60 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

@karthiknadig arbeitet bereits daran.

Seit 08.8.2024.

feature-request needs community feedback
Vorherrschende Sprache
TypeScript
Sterne
181
Forks
126
Ø Merge
2 T. 3 Std.
Gemergte PRs (30 T.)
3

Beschreibung

I want the ability to use the "Stop" button in the Python debugger in VS Code to send a SIGTERM (and/or maybe a SIGINT) to the running process, instead of just sending it SIGKILL (as it currently does).

This is the "Stop" button I'm talking about:
image

Proposed Solution

I'm thinking that a new option like this in the launch.json config file could be a good way to introduce this change without being a breaking change for the way everyone is used to the "stop" button working.

{
  "configurations": [
    {
      "name": "Python Debugger: Current File (Integrated Terminal)",
      "type": "debugpy",
      "request": "launch",
      "program": "${file}",
      "console": "integratedTerminal",
      "stop_action": "SIGKILL", // this would be a new enum-like config option, with values of "SIGKILL", "SIGINT", "SIGTERM", maybe others
    },
  ]
}
Possible additional ideas, more context
  • The minimum viable solution is described above.

  • SIGKILL (the current behavior) and SIGTERM are the two behaviors I'm personally chasing. SIGINT is another one that would be good to have as an option though.

  • As an extended implementation, the stop_action field could support a process like: send SIGTERM, wait 15 seconds, send SIGKILL.

  • This feature request stems from wanting to be able to test and debug the AWS Batch end-of-job behavior:

Under the hood, the Amazon ECS StopTask API call is used, which sends a SIGTERM value to the running container task. If after 30 seconds the container is still running, a SIGKILL signal is sent to forcibly stop the container. If the container handles the SIGTERM value gracefully and exits within 30 seconds from receiving it, no SIGKILL value is sent.

Related Previous Issues and Discussions

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.