microsoft / microsoft/vscode-pull-request-github

Behavior of "reply comment" and "collapse all" are odd if there are more than one comment in the same line.

Abierto
#4,564 0 comentarios 1 reacción 1 asignado Ver en GitHub

@alexr00 ya está trabajando en esto.

Desde el 23/2/2023.

bug
Lenguaje dominante
TypeScript
Estrellas
2.6k
Forks
796
Merge medio
1 d 4 h
PR fusionados (30 d)
46

Descripción

Does this issue occur when all extensions are disabled?: Yes/No

Steps to Reproduce:

  1. visit the files page of pull, https://github.com/huajiankan/personal/pull/2/files
  2. Add more than one comment in the same line
  3. visit https://github.dev/huajiankan/personal/pull/2/files to open the vscode web
  4. In the left part, there is 3 comments in the same line, click the collapse all icon -> all the comments in the right side collapsed, but the other two comments in the left side are not collapsed (I infer the correct behavior is collapse all the other comments except itself??)
  5. Reply the first comment in the left side, click "add comment" to submit the reply, then the reply will be added to the third one.
  6. Click update comment icon (the pencil icon), then the second or third comment is opened.

I guess, the comment feature doesn't consider this condition that more than one comment in the same line.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.