microsoft / microsoft/vscode-pull-request-github

Behavior of "reply comment" and "collapse all" are odd if there are more than one comment in the same line.

Open
#4,564 0 comments 1 reaction 1 assignee View on GitHub

@alexr00 is already working on this.

Since Feb 23, 2023.

bug
Dominant language
TypeScript
Stars
2.6k
Forks
795
Avg merge
1d 4h
Merged PRs (30d)
46

Description

Does this issue occur when all extensions are disabled?: Yes/No

Steps to Reproduce:

  1. visit the files page of pull, https://github.com/huajiankan/personal/pull/2/files
  2. Add more than one comment in the same line
  3. visit https://github.dev/huajiankan/personal/pull/2/files to open the vscode web
  4. In the left part, there is 3 comments in the same line, click the collapse all icon -> all the comments in the right side collapsed, but the other two comments in the left side are not collapsed (I infer the correct behavior is collapse all the other comments except itself??)
  5. Reply the first comment in the left side, click "add comment" to submit the reply, then the reply will be added to the third one.
  6. Click update comment icon (the pencil icon), then the second or third comment is opened.

I guess, the comment feature doesn't consider this condition that more than one comment in the same line.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.