microsoft / microsoft/TypeScript
Inconsistent import behavior would cause `.d.ts` to break.
Personne n'a encore pris cette issue.
- Langage dominant
- Go
- Étoiles
- 111k
- Forks
- 14.3k
- Merge moyen
- 1 j 19 h
- PR mergées (30 j)
- 117
Description
TL;DR;
The current inconsistent import behavior in different module mode (system or commonjs) would cause .d.ts to break (1.8 included).
Potential Solution
- Add a "module {system,commonjs}" directive and so that the
.d.tsfile will be processed correctly - Unify the import/export syntax and behavior
.d.tsuses a module agnostic import/export syntax
Context
The context of this problem is about module mapping (such as what jspm and typings supports).
Basically saying any module can be referenced by a different name to avoid module name collision. e.g. in a project that use two versions of jquery, one would be imported normally (import $ from 'jquery'), one would be imported with a different name (import $old from 'jquery@1.6').
In 1.8, with the support of allowSyntheticDefaultImports enables the behavior become similar (but if the user set it to false could still diverge). However the behavior of import * as A from 'abc'; and import dr = require('domready'); are still different.
Problem
The current (1.8) module support is working fine when creating package in TypeScript and distributing it as .js.
However it does not work if the package is distributed in .ts or with .d.ts.
The reason is that when distributing in the compiled form, the module mode used by the package author is captured in the .js file. When distributing .ts and .d.ts it relies on the consumer to use the same module mode as the package author intended.
This means if the package authors (including all typings authors) create the package using one module mode, and the consuming application/package use a different module mode, the system will fail.
It is worse if the consuming application/package uses multiple packages with disagreeing module mode.
Here are the original discussion:
https://github.com/typings/typings/issues/149
This is closely related to:
https://github.com/Microsoft/TypeScript/issues/7125
Please let me know if there are any confusion or missing information / context.
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
L’issue ne nomme aucun fichier, point d’entrée ni test. Commencez par lire les discussions liées typings/typings#149 et TypeScript#7125, puis comparez le comportement d’importation signalé de system et commonjs. Le travail est terminé lorsqu’un design convenu et testé pour les imports et exports .d.ts indépendants du module est défini.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- typescript
- Domaine
- compilers
- Type d'issue
- Fonctionnalité
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Activité
- À l'abandon
- Clarté
- À clarifier
- Accessibilité débutants
- 25/100