microsoft / microsoft/TypeScript
Inconsistent import behavior would cause `.d.ts` to break.
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Go
- Estrellas
- 111k
- Forks
- 14.3k
- Merge medio
- 1 d 19 h
- PR fusionados (30 d)
- 117
Descripción
TL;DR;
The current inconsistent import behavior in different module mode (system or commonjs) would cause .d.ts to break (1.8 included).
Potential Solution
- Add a "module {system,commonjs}" directive and so that the
.d.tsfile will be processed correctly - Unify the import/export syntax and behavior
.d.tsuses a module agnostic import/export syntax
Context
The context of this problem is about module mapping (such as what jspm and typings supports).
Basically saying any module can be referenced by a different name to avoid module name collision. e.g. in a project that use two versions of jquery, one would be imported normally (import $ from 'jquery'), one would be imported with a different name (import $old from 'jquery@1.6').
In 1.8, with the support of allowSyntheticDefaultImports enables the behavior become similar (but if the user set it to false could still diverge). However the behavior of import * as A from 'abc'; and import dr = require('domready'); are still different.
Problem
The current (1.8) module support is working fine when creating package in TypeScript and distributing it as .js.
However it does not work if the package is distributed in .ts or with .d.ts.
The reason is that when distributing in the compiled form, the module mode used by the package author is captured in the .js file. When distributing .ts and .d.ts it relies on the consumer to use the same module mode as the package author intended.
This means if the package authors (including all typings authors) create the package using one module mode, and the consuming application/package use a different module mode, the system will fail.
It is worse if the consuming application/package uses multiple packages with disagreeing module mode.
Here are the original discussion:
https://github.com/typings/typings/issues/149
This is closely related to:
https://github.com/Microsoft/TypeScript/issues/7125
Please let me know if there are any confusion or missing information / context.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
El issue no menciona archivos, puntos de entrada ni pruebas. Empieza leyendo las discusiones enlazadas typings/typings#149 y TypeScript#7125 y, a continuación, compara el comportamiento de importación reportado de system y commonjs. El trabajo estará terminado cuando exista un diseño acordado y probado para imports y exports .d.ts independientes del módulo.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- typescript
- Área
- compilers
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 25/100