microsoft / microsoft/TypeScript

Defer baseline comparisons until end of test

Aperta
#63,777 0 commenti 1 reazione 1 assegnatario Vedi su GitHub

Nessuno ha ancora preso questa issue.

Lingua principale
Go
Stelle
111k
Fork
14.3k
Merge medio
1g 19h
PR unite (30g)
117

Descrizione

Currently if you re-enable all failing fourslash tests (by clearing out failedtests.txt) and run

npm run convertfourslash
hereby baseline-accept

You'll get a baseline file for internal/fourslash/tests/gen/findReferencesAfterEdit_test.go

However, if you run npm run updatefailing, that test is still disabled in failedtests.txt.

I think it is possibly due to a bug in the baselining logic. My guess is that baselining is currently too eager. Any test that requests multiple baselines where an edit has occurred in between probably fails because any of the following might be true:

  1. the baselines were never accepted so the test could never succeed
  2. the second baseline call will always read the results of the first baseline, and is assumed to fail
  3. the second baseline was accepted, so the first call will always fail

I think we look at the original infrastructure for fourslash, every test actually compared against calculated baselines at the end of the test run. (I could be wrong though.)

Originally posted by @DanielRosenwasser in https://github.com/microsoft/typescript-go/pull/1450#discussion_r2229480973

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.