microsoft / microsoft/TypeScript

Defer baseline comparisons until end of test

Ouverte
#63,777 0 commentaires 1 réaction 1 personne assignée Voir sur GitHub

Personne n'a encore pris cette issue.

Langage dominant
Go
Étoiles
111k
Forks
14.3k
Merge moyen
2 j 4 h
PR mergées (30 j)
132

Description

Currently if you re-enable all failing fourslash tests (by clearing out failedtests.txt) and run

npm run convertfourslash
hereby baseline-accept

You'll get a baseline file for internal/fourslash/tests/gen/findReferencesAfterEdit_test.go

However, if you run npm run updatefailing, that test is still disabled in failedtests.txt.

I think it is possibly due to a bug in the baselining logic. My guess is that baselining is currently too eager. Any test that requests multiple baselines where an edit has occurred in between probably fails because any of the following might be true:

  1. the baselines were never accepted so the test could never succeed
  2. the second baseline call will always read the results of the first baseline, and is assumed to fail
  3. the second baseline was accepted, so the first call will always fail

I think we look at the original infrastructure for fourslash, every test actually compared against calculated baselines at the end of the test run. (I could be wrong though.)

Originally posted by @DanielRosenwasser in https://github.com/microsoft/typescript-go/pull/1450#discussion_r2229480973

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.