microsoft / microsoft/TypeScript
Typecheck code blocks in jsdoc
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Go
- Sterne
- 111k
- Forks
- 14.3k
- Ø Merge
- 2 T. 4 Std.
- Gemergte PRs (30 T.)
- 132
Beschreibung
🔍 Search Terms
jsdoc typecheck
✅ Viability Checklist
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
- This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
⭐ Suggestion
When a codeblock is created in jsdoc, apply typechecking on it as if it were part of the code in the file.
📃 Motivating Example
I create a method that has a non-trivial function signature (example is contrived)
type OtherType<TData> = { data: TData };
class Class<TData> {
doSomething<TNewData extends TData>(arg: OtherType<TNewData>): void;
}
I would like to document the idiomatic usage in jsdoc
/**
* Does something, example:
* ```ts
* const cls = new Class<{ x: number }>();
* cls.doSomething({ data: { x: 1, y: 2 } });
* ```
*/
If the function signature or underlying types change in any way, the typechecker will tell me to update the usages, but not the example.
The example becomes outdated potentially unknowingly, potentially causing bad code that could have been prevented if the example was typechecked.
💻 Use Cases
- What do you want to use this for?
Typecheck code blocks in jsdoc
- What shortcomings exist with current approaches?
Relying on implementations as the idiomatic way when the example in the jsdoc is intended the be the idiomatic way.
- What workarounds are you using in the meantime?
Inspection
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Es werden keine Dateien, Tests oder Einstiegspunkte genannt. Die Recherche sollte die JSDoc-Codeblöcke und Einstiegspunkte für die Typprüfung identifizieren und anschließend Tests definieren, die zeigen, dass Beispiele anhand der umgebenden Deklarationen geprüft werden, ohne das erzeugte JavaScript zu ändern.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- javascript, typescript
- Bereich
- compilers, documentation
- Issue-Typ
- Feature
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 30/100