microsoft / microsoft/TypeScript

Enables `implements` on abstract classes with protected members (usefull for generic mixins)

Aperta
#61,161 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Awaiting More Feedback Suggestion
Lingua principale
Go
Stelle
111k
Fork
14.3k
Merge medio
2g 4h
PR unite (30g)
132

Descrizione

### 🔍 Search Terms

implement abstract class with protected

### ✅ Viability Checklist

- [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
- [x] This wouldn't change the runtime behavior of existing JavaScript code
- [x] This could be implemented without emitting different JS based on the types of the expressions
- [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- [x] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
- [x] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals

### ⭐ Suggestion

Enable doing the following (currently this raises an error):

```ts
abstract class Base {
protected abstract foo(): void
}

class B implements Base {
protected foo() {}
}
```

### 📃 Motivating Example

This would be useful to declare "protected" interfaces, when we can't use `extends` as the child class is already extending another.

```ts
// interface
abstract class Base {
protected abstract foo(): void
}

class C {}

class B extends C implements Base {
protected foo() {}
}
```

Such need is frequent when using generic mixins: indeed, type manipulations inside generic functions (and mixins) are often quite troublesome, with unwanted type expansions/generalization (?). Then this is often better explicitly describe the returning type.

To do so, `abstract class` is the only way to properly describe the properties added by the mixin. However, if such class has protected properties, this raises TS error as classes with protected properties are no longer duck typing but "nominal" (?).

```ts
type Cstr = new(...args:any[]) => T;
type Mergeany,
B extends new(...args:any[])=>any
> = Omit
& (new() => (InstanceType & InstanceType))

function foo>(klass: T): Merge {
return class B extends klass implements Base {
protected foo() {}
}
}

class X extends foo(C) {}
```

### 💻 Use Cases

1. What do you want to use this for?

Easily describing generic mixins return type.

2. What shortcomings exist with current approaches?

Can't describe protected properties.

3. What workarounds are you using in the meantime?

Dirty casting, removing some type checks inside the generic mixin.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

La issue non fornisce alcun percorso di file o test. Inizia individuando la logica di type-checking e i test per la compatibilità delle classi con `implements` con membri protetti, quindi confronta gli esempi di classe astratta e generic mixin. Il lavoro è completato quando gli esempi superano il type-checking senza modificare il JavaScript emesso, con una copertura di regressione.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
typescript
Ambito
compilers
Tipo di issue
Funzionalità
Difficoltà
5/5
Tempo stimato
Più di una settimana
Stato di attività
Ferma
Chiarezza
Specificata chiaramente
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.