microsoft / microsoft/TypeScript
Enables `implements` on abstract classes with protected members (usefull for generic mixins)
- Langage dominant
- Go
- Étoiles
- 111k
- Forks
- 14.3k
- Merge moyen
- 2 j 4 h
- PR mergées (30 j)
- 132
Description
### 🔍 Search Terms
implement abstract class with protected
### ✅ Viability Checklist
- [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
- [x] This wouldn't change the runtime behavior of existing JavaScript code
- [x] This could be implemented without emitting different JS based on the types of the expressions
- [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- [x] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
- [x] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
### ⭐ Suggestion
Enable doing the following (currently this raises an error):
```ts
abstract class Base {
protected abstract foo(): void
}
class B implements Base {
protected foo() {}
}
```
### 📃 Motivating Example
This would be useful to declare "protected" interfaces, when we can't use `extends` as the child class is already extending another.
```ts
// interface
abstract class Base {
protected abstract foo(): void
}
class C {}
class B extends C implements Base {
protected foo() {}
}
```
Such need is frequent when using generic mixins: indeed, type manipulations inside generic functions (and mixins) are often quite troublesome, with unwanted type expansions/generalization (?). Then this is often better explicitly describe the returning type.
To do so, `abstract class` is the only way to properly describe the properties added by the mixin. However, if such class has protected properties, this raises TS error as classes with protected properties are no longer duck typing but "nominal" (?).
```ts
type Cstr = new(...args:any[]) => T;
type Mergeany,
B extends new(...args:any[])=>any
> = Omit & (new() => (InstanceType & InstanceType))
function foo>(klass: T): Merge {
return class B extends klass implements Base {
protected foo() {}
}
}
class X extends foo(C) {}
```
### 💻 Use Cases
1. What do you want to use this for?
Easily describing generic mixins return type.
2. What shortcomings exist with current approaches?
Can't describe protected properties.
3. What workarounds are you using in the meantime?
Dirty casting, removing some type checks inside the generic mixin.
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
L’issue ne fournit aucun chemin de fichier ou de test. Commencez par localiser la logique de vérification des types et les tests de compatibilité des classes avec `implements` et des membres protégés, puis comparez les exemples de classe abstraite et de mixin générique. Le travail est terminé lorsque les exemples passent la vérification des types sans modifier le JavaScript généré, avec une couverture de régression.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- typescript
- Domaine
- compilers
- Type d'issue
- Fonctionnalité
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Activité
- À l'abandon
- Clarté
- Clairement spécifiée
- Accessibilité débutants
- 35/100