microsoft / microsoft/TypeScript

Nested generic calls don't inherit outer inferences when their return types are intersections containing functions

Open
#58,833 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Domain: Intersection Help Wanted Possible Improvement
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
1d 19h
Merged PRs (30d)
117

Description

🔎 Search Terms

generic call inference intersection return type

🕗 Version & Regression Information
  • This is the behavior in every version I tried
⏯ Playground Link

https://www.typescriptlang.org/play/?ts=5.6.0-dev.20240611#code/JYOwLgpgTgZghgYwgAgMIHsQ2AcwDwAqAfMgN4CwAUMsgppAB5gBcyBA3FTaAG7oDWEVhWo1kACgasCASlZ9gAE06iaEBhAStJ0mcgC8JBcq7IAvirNUqizQBs4UFDACuIBGGCZaTuJEJE4nRYuKwYIfjEcsjGKjb2js5uHl4gyAC2AJ4AkiB8ggBCUAIQIAHiwMLI6praUmx6hjHoSubRIjQ6DfItJpRmyABkyGCZAA4Q6DDIwHGUCL6Q4h209OosZKtuGwDM5gA0prwlrFm5+RBFJSDLpmoaWhIMjSQrYsgMd2IA9N-IAHoAfi+NAYADo6NswWB0AAxYAaRTiABMMhU7zMh1EZhkWJxc1sCAcTmQrncnm8ZzyJXKlU2NUeXVkBiMvTawlMTOisVMDLquhZzSUljmCwgfggt1EwUYG1IW3ArD2mKO1MEpxyaslb2qDzqLzIII+Rt+AOBqjE4Mh4GhcIRECRqPRYhV2NxVHxVCAA

💻 Code
interface Config<T> {
  context: T;
  invoke: {
    (x: T): void;
    exec: (x: T) => void;
  };
}

declare function create<T>(config: Config<T>): void;

declare function myInvokeBroken<T>(i: { exec: (x: T) => void }): {
  (x: T): void;
} & typeof i;

create({
  context: { count: 3 },
  invoke: myInvokeBroken({
    exec: (x) => {
      x
      // ^?
      x.count.toFixed(2);
    },
  }),
});

declare function myInvoke<T>(i: { exec: (x: T) => void }): {
  (x: T): void;
  exec: (x: T) => void;
};

create({
  context: { count: 3 },
  invoke: myInvoke({
    exec: (x) => {
      x
      // ^?
      x.count.toFixed(2);
    },
  }),
});
🙁 Actual behavior

x doesn't get contextually typed based on the outer inferences in the myInvokeBroken example

🙂 Expected behavior

I would expect myInvokeBroken and myInvoke to work here in the same way. Their return types are the same. It's only that myInvokeBroken is using an intersection in its return type while myInvoke isn't

Additional information about the issue

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked TypeScript Playground repro and compare inference for the two generic calls, focusing on the intersection return type in myInvokeBroken versus the explicit callable-object return type in myInvoke. Trace the type-checker path that provides contextual types to the nested exec callback. Done means both examples contextually type x as { count: number } and x.count.toFixed(2) is accepted, with a regression test covering the difference.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.