microsoft / microsoft/TypeScript
computed keys with private element and super call should not be hoisted when targeted to ES2022
Aperta
@rbuckton ci sta già lavorando.
Dal 13/12/2023.
Bug
Domain: classes
Effort: Moderate
- Lingua principale
- Go
- Stelle
- 111k
- Fork
- 14.3k
- Merge medio
- 1g 19h
- PR unite (30g)
- 117
Descrizione
🔎 Search Terms
Private element, computed key, super call
🕗 Version & Regression Information
- This is a crash
- This changed between versions ______ and _______
- This changed in commit or PR _______
- This is the behavior in every version I tried, and I reviewed the FAQ for entries about Classes
- I was unable to test this on prior versions because _______
⏯ Playground Link
💻 Code
let capturedFooAccess, result;
class B {
constructor(v) {
capturedFooAccess = v
}
}
new class C extends B {
constructor() {
class A {
static #foo = 42;
static [super((t) => t.#foo)];
};
result = capturedFooAccess(A);
}
}
console.log({ result });
🙁 Actual behavior
The transformed code throws "Private field '#foo' must be declared in an enclosing class" because the private key IIFE is hoisted before class A.
🙂 Expected behavior
It should print { result: 42 }
The input is already ES2022, TS could have left it as-is.
Additional information about the issue
We can dodge this issue in ES2022 target, but I haven't figured out how to deal with the decorator expression. Either we lost the #foo access or the super() is moved to the scope of the underived class A.
let capturedFooAccess, result;
class B {
constructor(v) {
capturedFooAccess = v
}
}
new class C extends B {
constructor() {
class A {
@(super((t) => t.#foo), v => v) #foo = 42;
};
result = capturedFooAccess(A);
}
}
console.log({ result });
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Valutazione
Questa issue non è ancora stata valutata.