microsoft / microsoft/TypeScript
computed keys with private element and super call should not be hoisted when targeted to ES2022
Ouverte
@rbuckton y travaille déjà.
Depuis le 13/12/2023.
Bug
Domain: classes
Effort: Moderate
- Langage dominant
- Go
- Étoiles
- 111k
- Forks
- 14.4k
- Merge moyen
- 1 j 19 h
- PR mergées (30 j)
- 117
Description
🔎 Search Terms
Private element, computed key, super call
🕗 Version & Regression Information
- This is a crash
- This changed between versions ______ and _______
- This changed in commit or PR _______
- This is the behavior in every version I tried, and I reviewed the FAQ for entries about Classes
- I was unable to test this on prior versions because _______
⏯ Playground Link
💻 Code
let capturedFooAccess, result;
class B {
constructor(v) {
capturedFooAccess = v
}
}
new class C extends B {
constructor() {
class A {
static #foo = 42;
static [super((t) => t.#foo)];
};
result = capturedFooAccess(A);
}
}
console.log({ result });
🙁 Actual behavior
The transformed code throws "Private field '#foo' must be declared in an enclosing class" because the private key IIFE is hoisted before class A.
🙂 Expected behavior
It should print { result: 42 }
The input is already ES2022, TS could have left it as-is.
Additional information about the issue
We can dodge this issue in ES2022 target, but I haven't figured out how to deal with the decorator expression. Either we lost the #foo access or the super() is moved to the scope of the underived class A.
let capturedFooAccess, result;
class B {
constructor(v) {
capturedFooAccess = v
}
}
new class C extends B {
constructor() {
class A {
@(super((t) => t.#foo), v => v) #foo = 42;
};
result = capturedFooAccess(A);
}
}
console.log({ result });
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Évaluation
Cette issue n'a pas encore été évaluée.