microsoft / microsoft/TypeScript

Cannot assign readonly statics in static blocks

Aperta
#56,584 4 commenti 1 reazione 1 assegnatario Vedi su GitHub

@rbuckton ci sta già lavorando.

Dal 29/11/2023.

Needs Investigation
Lingua principale
Go
Stelle
111k
Fork
14.4k
Merge medio
1g 19h
PR unite (30g)
117

Descrizione

🔍 Search Terms

"assign readonly static in static block", "assign readonly static in static constructor"

✅ Viability Checklist
⭐ Suggestion

static readonly fields should be assignable within static code blocks, similar to how readonly fields are assignable in constructors. I've had a read through various issues, and those around the MR that introduced support for static blocks, but found no mention of dealing with readonly fields.

📃 Motivating Example

I'm making a variation on ringbufferjs, here, this.headerSize = ... shows an error without the //@ts-expect-error

type TypedArray =
  | Float32Array
  | Float64Array
  | Int8Array
  | Int16Array
  | Int32Array
  | BigInt64Array;
type TypedArrayConstructor =
  | Float32ArrayConstructor
  | Float64ArrayConstructor
  | Int8ArrayConstructor
  | Int16ArrayConstructor
  | Int32ArrayConstructor
  | BigInt64ArrayConstructor;

export default class LiveRingBuffer {
  private static readonly headerSize: number;

  static {
    const writePtrWidth = Uint32Array.BYTES_PER_ELEMENT;
    const readPtrWidth = Uint32Array.BYTES_PER_ELEMENT;
    const lapPtrWidth = Uint32Array.BYTES_PER_ELEMENT;
    //@ts-expect-error
    this.headerSize = writePtrWidth + readPtrWidth + lapPtrWidth;
  }

  static getStorageForCapacity(
    capacity: number,
    type: TypedArrayConstructor,
  ): SharedArrayBuffer {
    if (!type.BYTES_PER_ELEMENT) {
      throw TypeError('Pass in a ArrayBuffer subclass');
    }
    const storageWidth = (capacity + 1) * type.BYTES_PER_ELEMENT;
    const alignedHeaderWidth =
      Math.ceil(this.headerSize / type.BYTES_PER_ELEMENT) *
      type.BYTES_PER_ELEMENT;

    const bytes = alignedHeaderWidth + storageWidth;
    return new SharedArrayBuffer(bytes);
  }

  // ...
}
💻 Use Cases
  1. What do you want to use this for?
    See "Motivating Example"
  2. What shortcomings exist with current approaches?
    Current approach suppresses readonly error; alternative is to remove the readonly keyword, also not ideal since it really is readonly/const
  3. What workarounds are you using in the meantime?
    //@ts-expect-error hides the error and emits the desired code.

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.