microsoft / microsoft/TypeScript

Cannot assign readonly statics in static blocks

Abierto
#56,584 4 comentarios 1 reacción 1 asignado Ver en GitHub

@rbuckton ya está trabajando en esto.

Desde el 29/11/2023.

Needs Investigation
Lenguaje dominante
Go
Estrellas
111k
Forks
14.4k
Merge medio
1 d 19 h
PR fusionados (30 d)
117

Descripción

🔍 Search Terms

"assign readonly static in static block", "assign readonly static in static constructor"

✅ Viability Checklist
⭐ Suggestion

static readonly fields should be assignable within static code blocks, similar to how readonly fields are assignable in constructors. I've had a read through various issues, and those around the MR that introduced support for static blocks, but found no mention of dealing with readonly fields.

📃 Motivating Example

I'm making a variation on ringbufferjs, here, this.headerSize = ... shows an error without the //@ts-expect-error

type TypedArray =
  | Float32Array
  | Float64Array
  | Int8Array
  | Int16Array
  | Int32Array
  | BigInt64Array;
type TypedArrayConstructor =
  | Float32ArrayConstructor
  | Float64ArrayConstructor
  | Int8ArrayConstructor
  | Int16ArrayConstructor
  | Int32ArrayConstructor
  | BigInt64ArrayConstructor;

export default class LiveRingBuffer {
  private static readonly headerSize: number;

  static {
    const writePtrWidth = Uint32Array.BYTES_PER_ELEMENT;
    const readPtrWidth = Uint32Array.BYTES_PER_ELEMENT;
    const lapPtrWidth = Uint32Array.BYTES_PER_ELEMENT;
    //@ts-expect-error
    this.headerSize = writePtrWidth + readPtrWidth + lapPtrWidth;
  }

  static getStorageForCapacity(
    capacity: number,
    type: TypedArrayConstructor,
  ): SharedArrayBuffer {
    if (!type.BYTES_PER_ELEMENT) {
      throw TypeError('Pass in a ArrayBuffer subclass');
    }
    const storageWidth = (capacity + 1) * type.BYTES_PER_ELEMENT;
    const alignedHeaderWidth =
      Math.ceil(this.headerSize / type.BYTES_PER_ELEMENT) *
      type.BYTES_PER_ELEMENT;

    const bytes = alignedHeaderWidth + storageWidth;
    return new SharedArrayBuffer(bytes);
  }

  // ...
}
💻 Use Cases
  1. What do you want to use this for?
    See "Motivating Example"
  2. What shortcomings exist with current approaches?
    Current approach suppresses readonly error; alternative is to remove the readonly keyword, also not ideal since it really is readonly/const
  3. What workarounds are you using in the meantime?
    //@ts-expect-error hides the error and emits the desired code.

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.