microsoft / microsoft/TypeScript
improvements for non-experimental decorator types
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.4k
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 117
Description
🔍 Search Terms
github typescript decorator value type
✅ Viability Checklist
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
- This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
⭐ Suggestion
This is a request to add a new utility type because TypeScript added one for decorator contexts but not for values
The DecoratorContext type is nice for catching all context types:
function decorator(value: unknown, context: DecoratorContext) { // optionally use a more specific type.
// ...
}
But for value, there is not a good catch-all type.
📃 Motivating Example
If we have a context catch all type, why not also have a value catch all type, f.e. something like :
export type DecoratedValue = Constructor | Function | ClassAccessorDecoratorTarget<object, unknown> | undefined
💻 Use Cases
- What do you want to use this for? decorators whose code handles any value type
- What shortcomings exist with current approaches? we have to make the catchall for value ourselves, but we don't have to do that for context
- What workarounds are you using in the meantime? I make my own catchall (not that big a deal, but neither would making
DecoratorContextmyself be
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by locating the existing DecoratorContext declaration and the decorator type definitions it covers, then compare the proposed DecoratedValue members with the current type system. Done means an agreed catch-all value type is added without changing emitted JavaScript or existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100