microsoft / microsoft/TypeScript

Invalid recursive methods or functions

オープン
#55,643 コメント 6 件 リアクション 1 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

Needs Proposal Suggestion
主要言語
Go
スター
111k
フォーク
14.4k
平均マージ
1日 19時間
マージ済み PR(30日)
117

説明

🔍 Search Terms

Invalid recursive methods or functions not detected as error by typescript compiler during compile time

✅ Viability Checklist
  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
  • This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
⭐ Suggestion

// TypeScript compiler should detect invalid recursive functions and methods

// Invalid Recursions should not compile and should be reported as error during compile time

// Examples :
function testFunction(i:number) {
return testFunction(i); // compiler should warn this as invalid recursive function
}

let testFunction2 = function (i:number) {
return testFunction2(i); // compiler should warn this as invalid recursive function
}

let testFunction3 :(i:number)=>number = (i:number)=>{
return testFunction3(i); // compiler should warn this as invalid recursive function
}

testFunction(1); // compiler should warn this as invalid recursive function call
testFunction2(1); // compiler should warn this as invalid recursive function call
testFunction3(1); // compiler should warn this as invalid recursive function call

class Testing {
id:number=0;

test1():number{
return this.test1(); // compiler should warn this as invalid recursive method
}
}

const testing:Testing = new Testing();
console.log(testing.test1());// compiler should warn this as invalid recursive method call

//-----------------------------------------------------------------------------------------

// Correct Recursions should work fine and should not be reported as error by compiler

// Examples :
function factorial(x:number):number {

// if number is 0
if (x == 0) {
return 1;
}

// if number is positive
else {
return x * factorial(x - 1);
}
}

console.log(factorial(5));

📃 Motivating Example

// Invalid Recursions should not compile and should be reported as error during compile time

// Examples :
function testFunction(i:number) {
return testFunction(i); // compiler should warn this as invalid recursive function
}

let testFunction2 = function (i:number) {
return testFunction2(i); // compiler should warn this as invalid recursive function
}

let testFunction3 :(i:number)=>number = (i:number)=>{
return testFunction3(i); // compiler should warn this as invalid recursive function
}

testFunction(1); // compiler should warn this as invalid recursive function call
testFunction2(1); // compiler should warn this as invalid recursive function call
testFunction3(1); // compiler should warn this as invalid recursive function call

class Testing {
id:number=0;

test1():number{
return this.test1(); // compiler should warn this as invalid recursive method
}
}

const testing:Testing = new Testing();
console.log(testing.test1());// compiler should warn this as invalid recursive method call

//-----------------------------------------------------------------------------------------

// Correct Recursions should work fine and should not be reported as error by compiler

// Examples :
function factorial(x:number):number {

// if number is 0
if (x == 0) {
return 1;
}

// if number is positive
else {
return x * factorial(x - 1);
}
}

console.log(factorial(5));

💻 Use Cases

// Invalid Recursions should not compile and should be reported as error during compile time

// Examples :
function testFunction(i:number) {
return testFunction(i); // compiler should warn this as invalid recursive function
}

let testFunction2 = function (i:number) {
return testFunction2(i); // compiler should warn this as invalid recursive function
}

let testFunction3 :(i:number)=>number = (i:number)=>{
return testFunction3(i); // compiler should warn this as invalid recursive function
}

testFunction(1); // compiler should warn this as invalid recursive function call
testFunction2(1); // compiler should warn this as invalid recursive function call
testFunction3(1); // compiler should warn this as invalid recursive function call

class Testing {
id:number=0;

test1():number{
return this.test1(); // compiler should warn this as invalid recursive method
}
}

const testing:Testing = new Testing();
console.log(testing.test1());// compiler should warn this as invalid recursive method call

//-----------------------------------------------------------------------------------------

// Correct Recursions should work fine and should not be reported as error by compiler

// Examples :
function factorial(x:number):number {

// if number is 0
if (x == 0) {
return 1;
}

// if number is positive
else {
return x * factorial(x - 1);
}
}

console.log(factorial(5));

  1. What do you want to use this for?
    Java programmers can detect invalid recursive methods and functions in Intellij.
    Swift programmers can detect invalid recursive methods and functions in Xcode.
    But typescript programmers cannot detect invalid recursive methods and functions in VsCode or any other code editor.
    Invalid recursion check should exist in typescript as well which will allow to catch bugs during compile time .

  2. What shortcomings exist with current approaches?
    Java programmers can detect invalid recursive methods and functions in Intellij.
    Swift programmers can detect invalid recursive methods and functions in Xcode.
    But typescript programmers cannot detect invalid recursive methods and functions in VsCode or any other code editor.
    Invalid recursion check should exist in typescript as well which will allow to catch bugs during compile time .

  3. What workarounds are you using in the meantime?
    No workarounds at the moment for detecting typescript invalid recursive methods or functions during compile time .
    As a result runtime error happens for invalid recursive methods or functions in typescript.

コントリビューションガイド

コントリビューションガイドを開く

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

調査の方向性

この issue では、ファイル、テスト、コンパイラのエントリポイントが指定されていません。まず、自己呼び出しの例以外に何を無効な再帰とみなすのかを定義し、次に、階乗の例を許可しながらそれらのケースを診断で拒否する方法を決定してください。完了には、合意された動作とコンパイラテストが必要です。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
typescript
領域
compilers
issue の種類
機能追加
難易度
5/5
見積もり時間
1週間以上
活発さ
停滞
明瞭さ
説明が足りない
初心者へのやさしさ
28/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。