Outlier case in Excess Property detection in Union (a case that is -more- strict than it should be)

Bug Report

🔎 Search Terms

Excess Property Checks

(1)

From Release Notes 3.5

In TypeScript 3.5, the type-checker at least verifies that all the provided properties belong to some union member and have the appropriate type, meaning that the sample above correctly issues an error. Note that partial overlap is still permitted as long as the property types are valid.

🕗 Version & Regression Information

3.9.7 - 4.3.4 checked in playground to be the same.

⏯ Playground Link

Playground Link

💻 Code

// The expected rule for properties of union type (|) is  
// (1) must contain all required properties of at least one union member
// (2) may contain additional properties that belong to any union member

{
  type A2 = {a: string; b: string};
  type A3 = {a: string; b: boolean; c: boolean};
  type A4 = {a: string; b: boolean; c: number};

  {
    // THIS IS THE UNEXPECTED OUTLIER (compiler error happens unexpectedly)
    const b: A2|A3 = {a: '', b: '', c: true}; // ❌ assignment strictly checked, extra prop from A3 not allowed
  }
  {
    // BEHAVING AS EXPECTED (no compiler error)
    const b: A2|A3|A4 = {a: '', b: '', c: true}; // ✔ assignments allow extra props of other union types
  }
}

🙁 Actual behavior

The line item marked // THIS IS THE UNEXPECTED OUTLIER is rejected as invalid for A2|A3
even though
{a:''",b:""} contains all properties to satisfy A2, and c:true should be allowed by A3.

The oddity of that is accentuated by noting that the same value can be assigned to A2|A3|A4, where A4 differs only from A3 in having property-type c:number instead of c:boolean.

🙂 Expected behavior

The unexpected rejection of property c should be accepted as it is in the counterexample.

---

TL;DR : About the actual status quo limited type checking introduced with ts 3.5

From Release Notes 3.5

In TypeScript 3.5, the type-checker at least verifies that all the provided properties belong to some union member and have the appropriate type, meaning that the sample above correctly issues an error. Note that partial overlap is still permitted as long as the property types are valid.

That description does not actually match the observed status quo. For example, that rule would imply that an empty object could always be assigned to a union of object with required properties, and that is obviously false. So surely what the author meant was

... the type-checker at least verifies that all the required properties of some union member are provided ...

i.e., the rule for a set of properties to satisfy a union type (|) is

• (1) must contain all required properties of at least one union member
• (2) may contain additional properties that belong to any union member

This actual observed behavior is stronger excess property checking than the original verbiage.

That would still make the outlier behavior in this bug report a bug. It's just worth mentioning while we are on the topic. I have create a separate issue for this #44871.

リンクされた TypeScript Playground の再現例から始め、A2|A3 と A2|A3|A4 の代入結果を比較します。余分なプロパティのチェックの実装と関連するテストを読み、その後、外れ値の回帰テストケースを追加します。A2|A3 の代入が受け入れられ、既存の無効なプロパティのチェックを弱めていなければ完了です。