microsoft / microsoft/TypeScript
Ability to type check factory constructed source files
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Go
- Estrellas
- 111k
- Forks
- 14.3k
- Merge medio
- 2 d 4 h
- PR fusionados (30 d)
- 132
Descripción
Suggestion
It would be nice to have the ability to type check factory constructed source files.
For example, say I create some ASTs like so, where params.module.body is some foreign AST that I'm converting to a tsc AST:
const sourceFile = ts.factory.createSourceFile(
params.module.body.map(item => convertModuleItem(item)),
ts.factory.createToken(ts.SyntaxKind.EndOfFileToken), // side note... i'm unsure why this param exists
ts.NodeFlags.None,
);
sourceFile.fileName = params.fileName;
sourceFile.text = params.fileText;
setRange(sourceFile, params.module); // my own function that sets the range
...it would be better to be able to use these source files without having to implement all the necessary hacks. For example, not having to do...
(sourceFile as any).parseDiagnostics = [];
(sourceFile as any).bindDiagnostics = [];
...along with figuring out how to set many more internal properties (ex. identifiers, pragmas, imports, etc... etc...).
🔍 Search Terms
type check transformed AST source file
✅ Viability Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
💻 Use Cases
- Ability to do AST transformations then feed that back through the type checker without having to print out the AST to a string then reparsing that string to an AST using the TS compiler.
- Ability to take a non-tsc AST representation of an AST and construct it to a tsc AST using the factory methods. This would be useful in Deno as it is already parsing an AST with swc and so it could pass that AST over to the TS compiler for type checking.
Viability?
I understand this is a huge ask and the main reason I'm opening this is to ask how viable it is?
I believe the type checker would need to be changed to sparingly consult the source file text or node ranges and some of the code in the parser that sets internal properties would need to be extracted out to support it being lazily computed in addition to when it's parsed. Additionally, factory methods would have to clear the appropriate internal properties on nodes when they're transformed so that they will be lazily computed in the future when the type checker goes to retrieve them. Anything else?
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza leyendo el punto de entrada factory createSourceFile junto con los componentes internos del comprobador de tipos y del analizador sintáctico descritos en el issue. Se considerará terminado cuando los archivos fuente construidos por la factory puedan pasarse al comprobador de tipos sin establecer manualmente parseDiagnostics, bindDiagnostics, identifiers, pragmas, imports y otras propiedades internas.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- typescript
- Área
- compilers
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 20/100